pg.ddx.io  pgsql-general@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: Evgeny Morozov <postgresql3@realityexists.net>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL General <pgsql-general@postgresql.org>
Subject: Re: "PANIC: could not open critical system index 2662" - twice
Date: Mon, 8 May 2023 18:32:55 -0700
Message-ID: <20230509013255.fjrlpitnj3ltur76@awork3.anarazel.de> (raw)
In-Reply-To: <20230509004637.cgvmfwrbht7xm7p6@awork3.anarazel.de>
References: <01020187f07f341f-d1593cf8-4fc7-4186-b70c-0c8862a2aa32-000000@eu-west-1.amazonses.com>
	<CA+hUKGJ-yWVQGJQiK5XHpD+97Qc533mNr1L=-sOQmCqDYoMB-w@mail.gmail.com>
	<CA+hUKGJDfBEfqatSsV16XosCkr=3k2vb6X1mcbL_kdod_wHQwQ@mail.gmail.com>
	<4029098.1683422490@sss.pgh.pa.us>
	<CA+hUKGJ5zz8a6-D5ZQcoftZbAeBDs_h_3NL87TndKhW_2_aw1Q@mail.gmail.com>
	<01020187f6fa8f05-d1bd9975-48ec-4d8d-9ab7-75478400100d-000000@eu-west-1.amazonses.com>
	<20230508194748.6ydbfiozcfsynaq6@awork3.anarazel.de>
	<01020187fd0bfd45-d1609aba-f3c9-487a-b993-aac47f3f848a-000000@eu-west-1.amazonses.com>
	<20230508210400.ke4n5flpaxljtchd@awork3.anarazel.de>
	<20230509004637.cgvmfwrbht7xm7p6@awork3.anarazel.de>

Hi,

On 2023-05-08 17:46:37 -0700, Andres Freund wrote:
> My current gut feeling is that we should use datconnlimit == -2 to prevent
> connections after reaching DropDatabaseBuffers() in dropdb(), and use a new
> column in 16, for both createdb() and dropdb().

Attached is a rough prototype of that idea (only using datconnlimit == -2 for
now).

This would need a fair bit more polish. The tests are crappy and output stuff
to stderr and don't validate enough. The error messages are bad. No docs
changes. More comments about why datconnlimit == -2 is used. Etc.

But I think it should be sufficient to discuss whether this is a viable path.


I guess we need to move this to -hackers. Perhaps I'll post subsequent
versions below
https://www.postgresql.org/message-id/20230314174521.74jl6ffqsee5mtug%40awork3.anarazel.de ?

Greetings,

Andres Freund

Attachments:

  v1-0001-Handle-interrupted-DROP-DATABASE.patch (text/x-diff, 0B) download

view thread (65+ messages)  latest in thread

Message-ID: <20230509013255.fjrlpitnj3ltur76@awork3.anarazel.de>
Permalink:  ../20230509013255.fjrlpitnj3ltur76@awork3.anarazel.de/
Also on:    postgresql.org/message-id/20230509013255.fjrlpitnj3ltur76@awork3.anarazel.de

 ·  · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-general@postgresql.org
  Cc: andres@anarazel.de, postgresql3@realityexists.net, thomas.munro@gmail.com, tgl@sss.pgh.pa.us
  Subject: Re: "PANIC: could not open critical system index 2662" - twice
  In-Reply-To: <20230509013255.fjrlpitnj3ltur76@awork3.anarazel.de>
  References: <01020187f07f341f-d1593cf8-4fc7-4186-b70c-0c8862a2aa32-000000@eu-west-1.amazonses.com> <CA+hUKGJ-yWVQGJQiK5XHpD+97Qc533mNr1L=-sOQmCqDYoMB-w@mail.gmail.com> <CA+hUKGJDfBEfqatSsV16XosCkr=3k2vb6X1mcbL_kdod_wHQwQ@mail.gmail.com> <4029098.1683422490@sss.pgh.pa.us> <CA+hUKGJ5zz8a6-D5ZQcoftZbAeBDs_h_3NL87TndKhW_2_aw1Q@mail.gmail.com> <01020187f6fa8f05-d1bd9975-48ec-4d8d-9ab7-75478400100d-000000@eu-west-1.amazonses.com> <20230508194748.6ydbfiozcfsynaq6@awork3.anarazel.de> <01020187fd0bfd45-d1609aba-f3c9-487a-b993-aac47f3f848a-000000@eu-west-1.amazonses.com> <20230508210400.ke4n5flpaxljtchd@awork3.anarazel.de> <20230509004637.cgvmfwrbht7xm7p6@awork3.anarazel.de> <20230509013255.fjrlpitnj3ltur76@awork3.anarazel.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox