pg.ddx.io  pgsql-general@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Christian Convey <christian.convey@gmail.com>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Joy Arulraj <jarulraj@cs.cmu.edu>
Cc: Fabrízio Mello <fabriziomello@gmail.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: [GENERAL] C++ port of Postgres
Date: Sat, 10 Sep 2016 18:20:08 -0400
Message-ID: <21444.1473546008@sss.pgh.pa.us> (raw)
In-Reply-To: <CAPfS4ZySQ9gAxOZ6inZEtBUgxWypD2kDDGnRnSbjSWoGdK+WQg@mail.gmail.com>
References: <CABgyVxDBd3EvRdo-Rd6eo8QPEqV8=ShaU2SJfo16wfE0R-hXTA@mail.gmail.com>
	<CABgyVxCorVSTkVcjkPS06YYt9bPPamGNXAsQkCDFKXGvXZDh-w@mail.gmail.com>
	<CABgyVxCrHpk5SkU+7pVhze=dukx2SKqKNY8aOJstwaCRh=Y0Lg@mail.gmail.com>
	<CABgyVxBA24NnPri8BYQFjVdn2pgqcB=Q6MXFXdcwchUmJSAUPw@mail.gmail.com>
	<CAOmy0wLcyE3d=jbfpgoKtTicGoZ64AKKfEkG+ccXxtmajSBGeQ@mail.gmail.com>
	<CABgyVxBjX6VbnbHfZRSDJBav4xKH5vSLZqTpr989sMOb+jX+jA@mail.gmail.com>
	<CAMjNa7e7E81T3NqoReixYxrCFQpfWd+Mht0NhetW3bJB=Gs7Og@mail.gmail.com>
	<007001d1f786$d903fa90$8b0befb0$@andl.org>
	<00a52208-3199-5858-8846-2530b0bb34df@archidevsys.co.nz>
	<f7682c24-4271-1ff5-d963-053ecb0fce40@BlueTreble.com>
	<CA+Tgmoa8=kMNkOGDCZYR-L_PAoQ2Vdb9EmSV+=7pRv+J3u7_CA@mail.gmail.com>
	<27271.1471366764@sss.pgh.pa.us>
	<CA+TgmoZYjv9xWub1kbcSWC_RPg3qB_ELNBhQOki1g387JMyoVg@mail.gmail.com>
	<CABgyVxAO57r=cE0TdMn2XpBDO=d3cj289ep3xQu=8K-tWs79+w@mail.gmail.com>
	<66b61d8b-fe76-d4a9-a983-93a94444a2a6@BlueTreble.com>
	<CAPfS4Zz5P6fLMV9OszRUDMHDLf3nKV1HLcPNVtjkByzm! FgFBQA@mail.gmail.com>
	<14459.1473189179@sss.pgh.pa.us>
	<CAPfS4ZxZHQGBKsa7UUhfmW1J-fqRqMj9EauEK_p3u=upiSm8eQ@mail.gmail.com>
	<CAPfS4ZySQ9gAxOZ6inZEtBUgxWypD2kDDGnRnSbjSWoGdK+WQg@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

Christian Convey <christian.convey@gmail.com> writes:
>    If that's correct, then it sounds like the only way Joy's commit has
>    a chance of acceptance is if Peter's commit is rejected.
>    Because Peter's commit might be merged as part of the 2016-09
>    commitfest, but Joy's can show up until 2016-11 at the earliest.

No, we're not that rigid about it.  The commitfest mechanism is really
mostly meant to ensure that every submission does get looked at within a
reasonable amount of time and doesn't get forgotten about.  (We do tend
to be willing to tell new patches they've got to wait till the next fest,
but that's mainly when we're already feeling overloaded by what's in the
current queue.)  In this case it would be nonsensical to consider only
Peter's submission and not Joy's, because part of the issue is whether
one's better than the other.

> There seems to be a little ambiguity regarding the exact version of
> the code to be reviewed.  This is true for both Joy's and Peter's
> submissions:
>    * Joy's email provides a link to a Github repo, but does not specify
>      a particular commit (or even branch) in that repo: [2]
>    * In the email thread, Peter did provide a patch set: [3]
>      but the corresponding commitfest entry references a github branch: [4]

Well, at the point we're at here, it's probably not that important exactly
which version of a patchset you're looking at; I'd take the latest.

> Q4) Do we require that any submitted patches appear as attachments on
> the pgsql-hackers email list, or is a github URL good enough?

Actually, we *do* require that, mainly as a formality to show that the
author intended to submit it for inclusion in Postgres.  (We don't want
people coming back later and saying "hey, you ripped off this code from
my github repo without my permission".)  If we were seriously considering
adopting Joy's version then that would have to happen before anything got
merged.  But at this point it seems like we're in a very exploratory
phase and there's no need for legal niceties yet.

> Q5) (This question is more generic.)  I'm accustomed to using Github's
> pull-request system, where I can engage in dialog regarding specifc
> lines of a patch.  I haven't noticed anything similar being used for
> PG code reviews, but perhaps I'm just looking in the wrong places.
> Are all PG code reviews basically just back-and-forth email
> conversations on the pgsql-hackers list?

Yup, that's how we roll ... it's ancient habit from before there was
such a thing as git, let alone github, but we've not seen fit to change.
It does have the advantage that it's about equally amenable to high-
level discussions and line-by-line issues.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (76+ messages)  latest in thread

Message-ID: <21444.1473546008@sss.pgh.pa.us>
Permalink:  ../21444.1473546008@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/21444.1473546008@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-general@postgresql.org
  Cc: tgl@sss.pgh.pa.us, christian.convey@gmail.com, peter.eisentraut@2ndquadrant.com, jarulraj@cs.cmu.edu, fabriziomello@gmail.com, pgsql-hackers@postgresql.org
  Subject: Re: [GENERAL] C++ port of Postgres
  In-Reply-To: <21444.1473546008@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox