pg.ddx.io  pgsql-general@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Greg Stark <gsstark@mit.edu>
Cc: Stephan Szabo <sszabo@megazone23.bigpanda.com>
Cc: pgsql-general@postgresql.org
Subject: Re: index scan with index cond on first column doesn't recognize sort order of second column
Date: Thu, 13 Feb 2003 20:47:32 -0500
Message-ID: <3081.1045187252@sss.pgh.pa.us> (raw)
In-Reply-To: <87isvnk708.fsf@stark.dyndns.tv>
References: <20030213113156.T47380-100000@megazone23.bigpanda.com>
	<87u1f7kf1y.fsf@stark.dyndns.tv>
	<1915.1045178941@sss.pgh.pa.us>
	<87isvnk708.fsf@stark.dyndns.tv>

Greg Stark <gsstark@mit.edu> writes:
> But it might be better ordered. I think you may have missed the original
> context. In a query like:
>   SELECT * FROM table_a join table_b using (col2) WHERE a.col1 = $0
> Where there's an index on table_a(col1,col2) could use a merge join without a
> sort.

Yes.  The appropriate way to recognize that (without breaking things)
is to consider that the indexscan generates pathkeys (col2) because col1
can be assumed constant.  This is not truncate_useless_pathkeys's
business, however.  It would have to be done in the code that creates
the indexscan path to begin with.  (Ideally, we'd mark the path to show
that it could be considered to have either sort ordering (col1, col2)
or sort ordering (col2), so that it could match to either requirement.
I'm not sure if that's feasible with the current datastructures though.
Might have to make two copies of the path :-()

> I'm not clear on how removing the suffix is ever useful.

It reduces the number of alternatives that add_path will keep track of,
thus making for a combinatorial reduction in the cost of planning.

Actually you are barking up the wrong tree entirely; I'm pretty certain
that truncate_useless_pathkeys *doesn't* remove this pathkey, because it
should notice that it is relevant to the mergejoin condition.

			regards, tom lane



view thread (10+ messages)  latest in thread

Message-ID: <3081.1045187252@sss.pgh.pa.us>
Permalink:  ../3081.1045187252@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/3081.1045187252@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-general@postgresql.org
  Cc: tgl@sss.pgh.pa.us, gsstark@mit.edu, sszabo@megazone23.bigpanda.com
  Subject: Re: index scan with index cond on first column doesn't recognize sort order of second column
  In-Reply-To: <3081.1045187252@sss.pgh.pa.us>
  References: <20030213113156.T47380-100000@megazone23.bigpanda.com> <87u1f7kf1y.fsf@stark.dyndns.tv> <1915.1045178941@sss.pgh.pa.us> <87isvnk708.fsf@stark.dyndns.tv> <3081.1045187252@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox