From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michał Kłeczek <michal@kleczek.org>
Cc: PG-General Mailing List <pgsql-general@postgresql.org>
Subject: Re: postgres_fdw aggregate pushdown for group by with expressions
Date: Mon, 04 Mar 2024 10:22:28 -0500
Message-ID: <3598577.1709565748@sss.pgh.pa.us> (raw)
In-Reply-To: <5CE71232-CD60-4186-BBCB-2780D4C71F63@kleczek.org>
References: <AF30BDFB-7215-4E8C-BF11-C97573199D6C@kleczek.org>
<5FC17CB3-3048-455D-B638-B48949F78D06@kleczek.org>
<3299634.1709487773@sss.pgh.pa.us>
<5CE71232-CD60-4186-BBCB-2780D4C71F63@kleczek.org>
=?utf-8?Q?Micha=C5=82_K=C5=82eczek?= <michal@kleczek.org> writes:
> Does that mean that *any* expression containing text constants is not going to be pushed down??
> That would be a really serious issues I’d say.
If it contains text constants and not text variables, possibly so.
Keep in mind though that this rule is applied after constant-folding,
so that what we're left with is normally going to contain variables
at every level. extract() is problematic because it combines a
text constant with a datetime (collation-less) variable.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-general@postgresql.org
Cc: tgl@sss.pgh.pa.us, michal@kleczek.org
Subject: Re: postgres_fdw aggregate pushdown for group by with expressions
In-Reply-To: <3598577.1709565748@sss.pgh.pa.us>
References: <AF30BDFB-7215-4E8C-BF11-C97573199D6C@kleczek.org> <5FC17CB3-3048-455D-B638-B48949F78D06@kleczek.org> <3299634.1709487773@sss.pgh.pa.us> <5CE71232-CD60-4186-BBCB-2780D4C71F63@kleczek.org> <3598577.1709565748@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox