pg.ddx.io  pgsql-general@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andrew Dunstan <andrew@dunslane.net>
To: Jelte Fennema <postgres@jeltef.nl>
Cc: Pavel Stehule <pavel.stehule@gmail.com>
Cc: Kirk Wolak <wolakk@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Adding SHOW CREATE TABLE
Date: Fri, 26 May 2023 08:33:19 -0400
Message-ID: <36562be6-e660-4cf9-5b05-b73d5effecd0@dunslane.net> (raw)
In-Reply-To: <CAGECzQS=_QK=RzPokZ6XeLO9yOxwiFVbGXSn+O8yRK-Gyu5saw@mail.gmail.com>
References: <CAFEN2wxg0Vtj1gvk6Ms0L2CAutbycyxHZPiZSpW7eLsBc6VGnA@mail.gmail.com>
	<ZF6eIysBeQrXpz7r@tamriel.snowman.net>
	<1565715.1683923271@sss.pgh.pa.us>
	<ZF6jY1vqhxfGME+b@tamriel.snowman.net>
	<CACLU5mROQewFBFXG=C6DMvEtDgGZoF9k=m_bkTJYFgSNZptUkg@mail.gmail.com>
	<1aac01a1-d9db-8048-9bfa-1e4f9bb69a03@gmail.com>
	<CACLU5mQDDhdwu4Z8aRqNrc+UDLTE+GmfZPbxn39dha5m_EUEfQ@mail.gmail.com>
	<CAM8SmLV3RcGHsnhwk9=vAdhUGnYfCQ9xUsrBdXwyKn=_9wCDLw@mail.gmail.com>
	<CACLU5mSmZ0hoCbbkGBS7X2jczC8bmP5PE+w=BC=UvAp+36AoBw@mail.gmail.com>
	<CACLU5mQmq2r6FicCXm7Rj2JbyTyDdAdTEcSFAfO6bnK7x+S6aA@mail.gmail.com>
	<ZGa6lrLlZVIarDK4@tamriel.snowman.net>
	<6afd776b-45cf-2675-0cfe-981f1c6ade1d@dunslane.net>
	<CACLU5mR1KUSLQJwbB-b47j3iiH+R_Z+BXj=jtotY9KEFMzc0VA@mail.gmail.com>
	<CAFj8pRBhJxOcdFUzcG4wdQZoFA1ffkCt6z6xkD13QPN4qea3eQ@mail.gmail.com>
	<c82340a1-d893-3018-0d61-22966851d1e0@dunslane.net>
	<CAGECzQS=_QK=RzPokZ6XeLO9yOxwiFVbGXSn+O8yRK-Gyu5saw@mail.gmail.com>


On 2023-05-25 Th 09:23, Jelte Fennema wrote:
> On Mon, 22 May 2023 at 13:52, Andrew Dunstan<andrew@dunslane.net>  wrote:
>> A performant server side set of functions would be written in C and follow the patterns in ruleutils.c.
> We have lots of DDL ruleutils in our Citus codebase:
> https://github.com/citusdata/citus/blob/main/src/backend/distributed/deparser/citus_ruleutils.c
>
> I'm pretty sure we'd be happy to upstream those if that meant, we
> wouldn't have to update them for every postgres release.
>
> We also have the master_get_table_ddl_events UDF, which does what SHOW
> CREATE TABLE would do.


Sounds promising. I'd love to see a patch.


cheers


andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

view thread (46+ messages)  latest in thread

Message-ID: <36562be6-e660-4cf9-5b05-b73d5effecd0@dunslane.net>
Permalink:  ../36562be6-e660-4cf9-5b05-b73d5effecd0@dunslane.net/
Also on:    postgresql.org/message-id/36562be6-e660-4cf9-5b05-b73d5effecd0@dunslane.net

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-general@postgresql.org
  Cc: andrew@dunslane.net, postgres@jeltef.nl, pavel.stehule@gmail.com, wolakk@gmail.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: Adding SHOW CREATE TABLE
  In-Reply-To: <36562be6-e660-4cf9-5b05-b73d5effecd0@dunslane.net>
  References: <CAFEN2wxg0Vtj1gvk6Ms0L2CAutbycyxHZPiZSpW7eLsBc6VGnA@mail.gmail.com> <ZF6eIysBeQrXpz7r@tamriel.snowman.net> <1565715.1683923271@sss.pgh.pa.us> <ZF6jY1vqhxfGME+b@tamriel.snowman.net> <CACLU5mROQewFBFXG=C6DMvEtDgGZoF9k=m_bkTJYFgSNZptUkg@mail.gmail.com> <1aac01a1-d9db-8048-9bfa-1e4f9bb69a03@gmail.com> <CACLU5mQDDhdwu4Z8aRqNrc+UDLTE+GmfZPbxn39dha5m_EUEfQ@mail.gmail.com> <CAM8SmLV3RcGHsnhwk9=vAdhUGnYfCQ9xUsrBdXwyKn=_9wCDLw@mail.gmail.com> <CACLU5mSmZ0hoCbbkGBS7X2jczC8bmP5PE+w=BC=UvAp+36AoBw@mail.gmail.com> <CACLU5mQmq2r6FicCXm7Rj2JbyTyDdAdTEcSFAfO6bnK7x+S6aA@mail.gmail.com> <ZGa6lrLlZVIarDK4@tamriel.snowman.net> <6afd776b-45cf-2675-0cfe-981f1c6ade1d@dunslane.net> <CACLU5mR1KUSLQJwbB-b47j3iiH+R_Z+BXj=jtotY9KEFMzc0VA@mail.gmail.com> <CAFj8pRBhJxOcdFUzcG4wdQZoFA1ffkCt6z6xkD13QPN4qea3eQ@mail.gmail.com> <c82340a1-d893-3018-0d61-22966851d1e0@dunslane.net> <CAGECzQS=_QK=RzPokZ6XeLO9yOxwiFVbGXSn+O8yRK-Gyu5saw@mail.gmail.com> <36562be6-e660-4cf9-5b05-b73d5effecd0@dunslane.net>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox