pg.ddx.io  pgsql-general@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Vincas Dargis <vindrg@gmail.com>
Cc: pgsql-general <pgsql-general@lists.postgresql.org>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: Michael Paquier <michael@paquier.xyz>
Subject: Re: Issues cross-compiling libpq 14.x to MacOS armv8
Date: Wed, 1 Dec 2021 07:11:42 +0100
Message-ID: <5e38102f-4463-6e9e-9256-20ec6a07e8e5@enterprisedb.com> (raw)
In-Reply-To: <1633127.1638306242@sss.pgh.pa.us>
References: <0dc14a31-acaf-8cae-0df4-a87339b22bd9@gmail.com>
	<1628170.1638302387@sss.pgh.pa.us>
	<47B78E57-3D0F-4616-BF52-C07FA76AF0A7@yesql.se>
	<1633127.1638306242@sss.pgh.pa.us>

On 30.11.21 22:04, Tom Lane wrote:
> Daniel Gustafsson <daniel@yesql.se> writes:
>>> On 30 Nov 2021, at 20:59, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> AFAICS this is the only test in our configure script that is a hard
>>> fail when cross-compiling, and I don't see a reason for it to be that.
>>> We could just assume that /dev/urandom will be available --- that's no
>>> worse than a lot of the other optimistic assumptions that configure
>>> makes in that mode.
> 
>> Agreed, I don't see a problem with that.  I'm not terribly familiar with
>> supporting cross compilation in autoconf, would a reasonable approach be to
>> just remove the check altogether like the below sketch?
> 
> It seems like a useful test when *not* cross compiling, which is most
> of the time.

You still don't know whether the file will exist on the system you are 
running this on.

> (I'm a bit surprised that the AC_CHECK_FILE macro doesn't provide
> an action-if-cross-compiling option, but it apparently doesn't.)

Because you are only supposed to look for files that you need during the 
build.





view thread (12+ messages)  latest in thread

Message-ID: <5e38102f-4463-6e9e-9256-20ec6a07e8e5@enterprisedb.com>
Permalink:  ../5e38102f-4463-6e9e-9256-20ec6a07e8e5@enterprisedb.com/
Also on:    postgresql.org/message-id/5e38102f-4463-6e9e-9256-20ec6a07e8e5@enterprisedb.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-general@postgresql.org
  Cc: peter.eisentraut@enterprisedb.com, tgl@sss.pgh.pa.us, daniel@yesql.se, vindrg@gmail.com, magnus@hagander.net, michael@paquier.xyz
  Subject: Re: Issues cross-compiling libpq 14.x to MacOS armv8
  In-Reply-To: <5e38102f-4463-6e9e-9256-20ec6a07e8e5@enterprisedb.com>
  References: <0dc14a31-acaf-8cae-0df4-a87339b22bd9@gmail.com> <1628170.1638302387@sss.pgh.pa.us> <47B78E57-3D0F-4616-BF52-C07FA76AF0A7@yesql.se> <1633127.1638306242@sss.pgh.pa.us> <5e38102f-4463-6e9e-9256-20ec6a07e8e5@enterprisedb.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox