public inbox for [email protected]  
help / color / mirror / Atom feed
Re: Using Expanded Objects other than Arrays from plpgsql
5+ messages / 3 participants
[nested] [flat]

* Re: Using Expanded Objects other than Arrays from plpgsql
@ 2025-02-03 19:15 Andrey Borodin <[email protected]>
  2025-02-06 21:05 ` Re: Using Expanded Objects other than Arrays from plpgsql Tom Lane <[email protected]>
  0 siblings, 1 reply; 5+ messages in thread

From: Andrey Borodin @ 2025-02-03 19:15 UTC (permalink / raw)
  To: Tom Lane <[email protected]>; +Cc: Pavel Borisov <[email protected]>; Michel Pelletier <[email protected]>; Pavel Stehule <[email protected]>; [email protected]



> On 3 Feb 2025, at 23:18, Tom Lane <[email protected]> wrote:
> 
> But I don't want to think of
> EEOP_PARAM_CALLBACK as being specifically tied to PL/pgSQL.

I've found 1 users on Github [0]. And a lot of copied code like [1]. And there might be some unindexed cases.
Let's keep paramarg2.


Best regards, Andrey Borodin.
[0] https://github.com/wanglinn/xadb/blob/7695b7edcb0a89f3173b648c0da5b953538f2aa9/src/backend/pgxc/pool...
[1] https://github.com/babelfish-for-postgresql/babelfish_extensions/blob/376cf488804fa02f9b1db5bbfbe74e...





^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: Using Expanded Objects other than Arrays from plpgsql
  2025-02-03 19:15 Re: Using Expanded Objects other than Arrays from plpgsql Andrey Borodin <[email protected]>
@ 2025-02-06 21:05 ` Tom Lane <[email protected]>
  2025-02-07 10:40   ` Re: Using Expanded Objects other than Arrays from plpgsql Andrey Borodin <[email protected]>
  0 siblings, 1 reply; 5+ messages in thread

From: Tom Lane @ 2025-02-06 21:05 UTC (permalink / raw)
  To: Andrey Borodin <[email protected]>; +Cc: Pavel Borisov <[email protected]>; Michel Pelletier <[email protected]>; Pavel Stehule <[email protected]>; [email protected]

Andrey Borodin <[email protected]> writes:
> I've found 1 users on Github [0]. And a lot of copied code like [1]. And there might be some unindexed cases.
> Let's keep paramarg2.

Yeah, sounds like the best path if there are already outside users
of paramarg.

Do you have any further comments on this patch?

			regards, tom lane






^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: Using Expanded Objects other than Arrays from plpgsql
  2025-02-03 19:15 Re: Using Expanded Objects other than Arrays from plpgsql Andrey Borodin <[email protected]>
  2025-02-06 21:05 ` Re: Using Expanded Objects other than Arrays from plpgsql Tom Lane <[email protected]>
@ 2025-02-07 10:40   ` Andrey Borodin <[email protected]>
  2025-02-11 17:50     ` Re: Using Expanded Objects other than Arrays from plpgsql Tom Lane <[email protected]>
  0 siblings, 1 reply; 5+ messages in thread

From: Andrey Borodin @ 2025-02-07 10:40 UTC (permalink / raw)
  To: Tom Lane <[email protected]>; +Cc: Pavel Borisov <[email protected]>; Michel Pelletier <[email protected]>; Pavel Stehule <[email protected]>; [email protected]



> On 7 Feb 2025, at 02:05, Tom Lane <[email protected]> wrote:
> 
> Do you have any further comments on this patch?

No, all steps of the patch set look good to me.


Best regards, Andrey Borodin.






^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: Using Expanded Objects other than Arrays from plpgsql
  2025-02-03 19:15 Re: Using Expanded Objects other than Arrays from plpgsql Andrey Borodin <[email protected]>
  2025-02-06 21:05 ` Re: Using Expanded Objects other than Arrays from plpgsql Tom Lane <[email protected]>
  2025-02-07 10:40   ` Re: Using Expanded Objects other than Arrays from plpgsql Andrey Borodin <[email protected]>
@ 2025-02-11 17:50     ` Tom Lane <[email protected]>
  2025-02-13 13:02       ` Re: Using Expanded Objects other than Arrays from plpgsql Pavel Borisov <[email protected]>
  0 siblings, 1 reply; 5+ messages in thread

From: Tom Lane @ 2025-02-11 17:50 UTC (permalink / raw)
  To: Andrey Borodin <[email protected]>; +Cc: Pavel Borisov <[email protected]>; Michel Pelletier <[email protected]>; Pavel Stehule <[email protected]>; [email protected]

Andrey Borodin <[email protected]> writes:
> On 7 Feb 2025, at 02:05, Tom Lane <[email protected]> wrote:
>> Do you have any further comments on this patch?

> No, all steps of the patch set look good to me.

Pushed then.  Thanks for reviewing!

			regards, tom lane






^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: Using Expanded Objects other than Arrays from plpgsql
  2025-02-03 19:15 Re: Using Expanded Objects other than Arrays from plpgsql Andrey Borodin <[email protected]>
  2025-02-06 21:05 ` Re: Using Expanded Objects other than Arrays from plpgsql Tom Lane <[email protected]>
  2025-02-07 10:40   ` Re: Using Expanded Objects other than Arrays from plpgsql Andrey Borodin <[email protected]>
  2025-02-11 17:50     ` Re: Using Expanded Objects other than Arrays from plpgsql Tom Lane <[email protected]>
@ 2025-02-13 13:02       ` Pavel Borisov <[email protected]>
  0 siblings, 0 replies; 5+ messages in thread

From: Pavel Borisov @ 2025-02-13 13:02 UTC (permalink / raw)
  To: Tom Lane <[email protected]>; +Cc: Andrey Borodin <[email protected]>; Michel Pelletier <[email protected]>; Pavel Stehule <[email protected]>; [email protected]

On Tue, 11 Feb 2025 at 21:50, Tom Lane <[email protected]> wrote:
>
> Andrey Borodin <[email protected]> writes:
> > On 7 Feb 2025, at 02:05, Tom Lane <[email protected]> wrote:
> >> Do you have any further comments on this patch?
>
> > No, all steps of the patch set look good to me.
>
> Pushed then.  Thanks for reviewing!
Thanks to Michel and everyone working on the patch!

Regards,
Pavel Borisov






^ permalink  raw  reply  [nested|flat] 5+ messages in thread


end of thread, other threads:[~2025-02-13 13:02 UTC | newest]

Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2025-02-03 19:15 Re: Using Expanded Objects other than Arrays from plpgsql Andrey Borodin <[email protected]>
2025-02-06 21:05 ` Tom Lane <[email protected]>
2025-02-07 10:40   ` Andrey Borodin <[email protected]>
2025-02-11 17:50     ` Tom Lane <[email protected]>
2025-02-13 13:02       ` Pavel Borisov <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox