pg.ddx.io  pgsql-general@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alban Hertroys <haramrae@gmail.com>
To: Thorsten Glaser <tg@evolvis.org>
Cc: pgsql-general@lists.postgresql.org
Subject: Re: DISTINCT *and* ORDER BY in aggregate functions on expressions(!)y
Date: Sat, 4 Mar 2023 11:48:24 +0100
Message-ID: <82E2D483-67A9-480D-8671-8937D077840B@gmail.com> (raw)
In-Reply-To: <9e86b053-a29a-a82-78f0-1228a391edc3@evolvis.org>
References: <23d08470-aaa8-afca-dfd7-37261487a1f8@evolvis.org>
	<CAKFQuwZ1f0zmVsFpYeNL8c=waGSCJB5K4AmkqzdXXHXB3XX3Lw@mail.gmail.com>
	<c02191c1-64a8-3350-6853-784bf5ce57@evolvis.org>
	<559416.1677547978@sss.pgh.pa.us>
	<9fc8e12b-f943-c633-a37-254915f819a0@evolvis.org>
	<D9BE942C-58B4-48D0-9DA1-2B7514BA4881@gmail.com>
	<9da4cb5a-81bb-23a4-8261-6ba8a29579af@evolvis.org>
	<5AF0C3F0-4D5A-4198-B58B-6E7D4994969B@gmail.com>
	<9e86b053-a29a-a82-78f0-1228a391edc3@evolvis.org>


> On 3 Mar 2023, at 20:32, Thorsten Glaser <tg@evolvis.org> wrote:
> 
> On Fri, 3 Mar 2023, Alban Hertroys wrote:
> 
>> You can rewrite that into something like this:
>> 
>> select jsonb_build_object('opening_times’,
>> 	obj
>> 	ORDER BY
>> 	    obj->>'weekday’,
>> 	    obj->>'from_hour’,
>> 	    obj->>'to_hour')
>> )
>> from cot
>> cross join lateral jsonb_agg(jsonb_build_object(
>> 		'weekday', cot.weekday,
>> 		'from_hour', cot.from_hour,
>> 		'to_hour', cot.to_hour) obj
> 
> But isn’t that the same as with a regular LEFT JOIN?

Similar, but not the same, I’d say.

I do now notice that I made some copying errors there, I was a bit nauseous at that time.
That should have read:

>> select jsonb_build_object('opening_times’,
>>     jsonb_agg(obj
>> 	ORDER BY
>> 	    obj->>'weekday’,
>> 	    obj->>'from_hour’,
>> 	    obj->>'to_hour')
>> )
>> from cot
>> cross join lateral jsonb_build_object(
>> 		'weekday', cot.weekday,
>> 		'from_hour', cot.from_hour,
>> 		'to_hour', cot.to_hour) obj


The lateral join applies the function to each row returned from the left side of the join and enriches that row with the function result.
I used a cross join because there is no join condition to apply to the lateral, otherwise you could also use an inner join on true.

I think you could also have used an implicit Cartesian product (using ‘,’ for the join), and that in that case the lateral would be implied. I prefer explicit notation though.

A left join wouldn’t make much sense here, unless the function could return NULL - for example if it were a function marked as STRICT and some of the input parameter values (from the table) could be NULL.


>>>   cgwaj AS (
>>> 	SELECT cgwa.id AS id, jsonb_build_object(
>>> 		'weekday', cgwa.weekday,
>>> 		'forenoon', cgwa.forenoon,
>>> 		'afternoon', cgwa.afternoon,
>>> 		'evening', cgwa.evening) AS obj
>>> 	FROM core_generalworkavailability cgwa
> 
> plus

There are some differences.

You need a sub-select, which in turn creates its own result set. It’s up to the planner whether the left or the right side gets executed first, after which the results of the other side of the join get merged to this, or whether this can all be collected in one go. That’s up to the query planner to decide though, and it could be right.

>>> 	LEFT JOIN cgwaj ON cgwaj.id=cppwt.generalworkavailability_id
> 
> With the addition that I can aggregate…

You can do so in both situations, but I guess that confusion stems from my copy/paste mistake.

In my experience, lateral joins go well with the jsonb functions. They tend to reduce code repetition when referencing object members, such as in your case.

Regards,

Alban Hertroys
--
There is always an exception to always.









view thread (14+ messages)  latest in thread

Message-ID: <82E2D483-67A9-480D-8671-8937D077840B@gmail.com>
Permalink:  ../82E2D483-67A9-480D-8671-8937D077840B@gmail.com/
Also on:    postgresql.org/message-id/82E2D483-67A9-480D-8671-8937D077840B@gmail.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-general@postgresql.org
  Cc: haramrae@gmail.com, tg@evolvis.org
  Subject: Re: DISTINCT *and* ORDER BY in aggregate functions on expressions(!)y
  In-Reply-To: <82E2D483-67A9-480D-8671-8937D077840B@gmail.com>
  References: <23d08470-aaa8-afca-dfd7-37261487a1f8@evolvis.org> <CAKFQuwZ1f0zmVsFpYeNL8c=waGSCJB5K4AmkqzdXXHXB3XX3Lw@mail.gmail.com> <c02191c1-64a8-3350-6853-784bf5ce57@evolvis.org> <559416.1677547978@sss.pgh.pa.us> <9fc8e12b-f943-c633-a37-254915f819a0@evolvis.org> <D9BE942C-58B4-48D0-9DA1-2B7514BA4881@gmail.com> <9da4cb5a-81bb-23a4-8261-6ba8a29579af@evolvis.org> <5AF0C3F0-4D5A-4198-B58B-6E7D4994969B@gmail.com> <9e86b053-a29a-a82-78f0-1228a391edc3@evolvis.org> <82E2D483-67A9-480D-8671-8937D077840B@gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox