public inbox for [email protected]  

help / color / mirror / Atom feed

From: Igor Korot <[email protected]>
To: David G. Johnston <[email protected]>
Cc: pgsql-generallists.postgresql.org <[email protected]>
Subject: Re: How to properly fix memory leak
Date: Sat, 26 Apr 2025 00:12:59 -0500
Message-ID: <CA+FnnTx5QBqs2WFAu+Bznv2z73i+j8aZXGDMB0ocE=Wb6hy4eA@mail.gmail.com> (raw)
In-Reply-To: <CAKFQuwbZxuVPZTwMmxqBYUFNajCPFKrOY12co+0pFK-eTHcEuA@mail.gmail.com>
References: <CA+FnnTyR9AoJx-3zuvgudeYmUTiNcfpAucUh0ZTcs=Ajy49qVA@mail.gmail.com>
	<CAKFQuwZKp_FWZ0mi9H8th+fh70KeoV=4_6uB40TvQ9r1Q04UhA@mail.gmail.com>
	<CA+FnnTwW6bsN3zJSHYbc7cGUi_4+PBOmHx+L5bbupwKkUio9tQ@mail.gmail.com>
	<CAKFQuwbZxuVPZTwMmxqBYUFNajCPFKrOY12co+0pFK-eTHcEuA@mail.gmail.com>

Hi, David,

On Fri, Apr 25, 2025 at 11:55 PM David G. Johnston
<[email protected]> wrote:
>
> On Friday, April 25, 2025, Igor Korot <[email protected]> wrote:
>>
>>
>> And the error case was handled correctly, right?
>
>
> Seems like answering that requires knowing what the query is or can be.  I also have no idea what idiomatic code looks like.  Though, I’d probably use PQresultErrorMessage and check affirmatively for the tuples and error cases and have a final else should the status be something unexpected.

Understood.

Below is the full function:

[code]
int PostgresDatabase::PopulateTablespaces(std::vector<std::wstring> &errorMsg)
{
    int result = 0;
    std::wstring errorMessage;
    std::wstring query = L"SELECT * FROM pg_tablespace;";
    auto res = PQexec( m_db, m_pimpl->m_myconv.to_bytes( query.c_str()
).c_str() );      /* ask for binary results */
    if( PQresultStatus( res ) != PGRES_TUPLES_OK )
    {
        auto err = m_pimpl->m_myconv.from_bytes( PQerrorMessage( m_db ) );
        errorMsg.push_back( L"Update validation table: " + err );
        result = 1;
    }
    else
    {
        for( int i = 0; i < PQntuples( res ); i++ )
        {
            auto temp1 = m_pimpl->m_myconv.from_bytes( PQgetvalue(
res, i, 1 ) );
            m_tablespaces.push_back( temp1 );
        }
    }
    PQclear( res );
    return result;
}
[/code]

Thank you.

>
> David J.
>

view thread (5+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: How to properly fix memory leak
  In-Reply-To: <CA+FnnTx5QBqs2WFAu+Bznv2z73i+j8aZXGDMB0ocE=Wb6hy4eA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox