public inbox for [email protected]  

help / color / mirror / Atom feed

From: Bernice Southey <[email protected]>
To: [email protected]
Subject: Indentation in a patch
Date: Tue, 25 Nov 2025 18:14:57 +0000
Message-ID: <CAEDh4nxfE_dte840rgD-YM8M57qijYGv-R75MLgPRx-+=pS6hQ@mail.gmail.com> (raw)

Hi,
I'm having a fight with git and indentation for my first ever patch
attempt.  I'm just adding an if statement around an existing 70-line
code-block. It's a very simple few lines with --ignore-all-space. But
the patch file is noisy because of 140 lines of +/- indentation diffs.

I then realised the standard was tabs, and after fixing my spaces,
things got even worse. The 140 lines now interleave in many unreadable
chunks. I've tried different diff-algorithms, but they make no
difference. I'm tempted to submit my patch without indenting the
if-block, and an explanation. Any better suggestions?

While I'm asking, I added a regression test and ran make check-world
with the TAP tests. Anything else I should do before sending it to
hackers?

Thanks, Bernice

view thread (3+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Indentation in a patch
  In-Reply-To: <CAEDh4nxfE_dte840rgD-YM8M57qijYGv-R75MLgPRx-+=pS6hQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox