public inbox for [email protected]  

help / color / mirror / Atom feed

From: David G. Johnston <[email protected]>
To: Nathan Bossart <[email protected]>
Cc: Fujii Masao <[email protected]>
Cc: Robert Treat <[email protected]>
Cc: Laurenz Albe <[email protected]>
Cc: Gurjeet Singh <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: Will Storey <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: Postgres Hackers <[email protected]>
Subject: Re: Disabling vacuum truncate for autovacuum
Date: Fri, 21 Mar 2025 08:54:55 -0700
Message-ID: <CAKFQuwaduAUn=v-vnTkW0hXs2G5Yv0nxcHDDiuviet4FTxFzMQ@mail.gmail.com> (raw)
In-Reply-To: <Z9xaroJSrS44HyKG@nathan>
References: <CABwTF4WFp-oNSm6utik6g-1HZBxijTJBcuX7BKD8MYqza+KMnw@mail.gmail.com>
	<[email protected]>
	<CABV9wwNagobmRMCxs0dKqWmKXaQTUQj+oOOTw=fsPAgbBfVhew@mail.gmail.com>
	<Z9g8a4HGLUcSo96v@nathan>
	<Z9ohFZtDaZnkch7u@nathan>
	<[email protected]>
	<Z9rlb0jgNLm8ULAB@nathan>
	<Z9rsMX5ZOL5E0cQy@nathan>
	<Z9wxuP1AY303wAxM@nathan>
	<CAKFQuwYKtEUYKS+18gRs-xPhn0qOJgM2KGyyWVCODHuVn9F-XQ@mail.gmail.com>
	<Z9xaroJSrS44HyKG@nathan>

On Thu, Mar 20, 2025 at 11:13 AM Nathan Bossart <[email protected]>
wrote:

>
> How does something like this look for the comment?
>
>         /*
>          * isset_offset is an optional offset of a field in the result
> struct
>          * that stores whether the value is explicitly set for the
> relation or
>          * has just picked up the default value.  In most cases, this can
> be
>          * deduced by giving the reloption a special default value (e.g.,
> -2 is
>          * a common one for integer reloptions), but this isn't always
>          * possible.  One notable example is Boolean reloptions, where it's
>          * difficult to discern the source of the value.  This offset is
> only
>          * used if given a value greater than zero.
>          */
>         int                     isset_offset;
>
>
>
I didn't actually come back to this before writing my comment.

I'm glad they both say basically the same thing.

I'm still partial to mine but yours probably fits the overall style of the
codebase better.

David J.

view thread (5+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Disabling vacuum truncate for autovacuum
  In-Reply-To: <CAKFQuwaduAUn=v-vnTkW0hXs2G5Yv0nxcHDDiuviet4FTxFzMQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox