public inbox for [email protected]  

help / color / mirror / Atom feed

From: Ron Johnson <[email protected]>
To: pgsql-general <[email protected]>
Subject: Re: PG 14 pg_basebackup accepts --compress=server-zst option
Date: Fri, 7 Jun 2024 08:04:33 -0400
Message-ID: <CANzqJaAAJmAhgbYYx1T-+-A_myAEOLgDbzE3m5zfOQMwNzcCQQ@mail.gmail.com> (raw)
In-Reply-To: <CAKFQuwYhAbOwvMfCSWg4VMAWDUX1kCZAdG1XQMKnWWFZYyOpTA@mail.gmail.com>
References: <CANzqJaB=-AUnoXh+V6ayLPbRut7yNt7utL-=0+OK4hdh35-cTQ@mail.gmail.com>
	<CAAPsdhfQ0GvDuNeMZpe_sccHcM=7dHZq=C6wXbM8zFr_X2FD3g@mail.gmail.com>
	<CAKFQuwYhAbOwvMfCSWg4VMAWDUX1kCZAdG1XQMKnWWFZYyOpTA@mail.gmail.com>

On Fri, Jun 7, 2024 at 12:32 AM David G. Johnston <
[email protected]> wrote:

> On Thursday, June 6, 2024, Kashif Zeeshan <[email protected]> wrote:
>
>> Hi
>>
>> On Fri, Jun 7, 2024 at 6:54 AM Ron Johnson <[email protected]>
>> wrote:
>>
>>>
>>> https://www.postgresql.org/docs/14/app-pgbasebackup.html doesn't
>>> mention "--compress=[{client|server}-]method".  That first appears in the
>>> v15 docs.
>>>
>>> And yet pg_basebackup doesn't complain about an invalid option.
>>> (Technically, this is a bug; I first noticed it a week after copying a
>>> script from a PG 15 server to five PG 14 servers, and running it quite a
>>> few times without fail.)
>>>
>>
> Seems a bit suspect, but as your script doesn’t mention tar the option
> itself is apparently ignored, I guess silently.
>

Does this mean that "--compress=server-zst" is only relevant with
--format=tar?


> Assuming this isn’t an actual regression in behavior in a patch-released
> older version
>

My apologies for not mentioning the version: 14.12-1PGDG-rhel8.


> I don’t see us adding an error message at this point.
>

Me neither.  It just seemed odd.

view thread (5+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: PG 14 pg_basebackup accepts --compress=server-zst option
  In-Reply-To: <CANzqJaAAJmAhgbYYx1T-+-A_myAEOLgDbzE3m5zfOQMwNzcCQQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox