public inbox for [email protected]  
help / color / mirror / Atom feed
Postgres_FDW doc doesn't specify TYPE support in Remote Execution Options
2+ messages / 2 participants
[nested] [flat]

* Postgres_FDW doc doesn't specify TYPE support in Remote Execution Options
@ 2024-04-09 10:19 Rajan Pandey <[email protected]>
  2024-04-09 10:36 ` Re: Postgres_FDW doc doesn't specify TYPE support in Remote Execution Options Laurenz Albe <[email protected]>
  0 siblings, 1 reply; 2+ messages in thread

From: Rajan Pandey @ 2024-04-09 10:19 UTC (permalink / raw)
  To: [email protected]

Hi,
I was reading
https://www.postgresql.org/docs/current/postgres-fdw.html#POSTGRES-FDW-OPTIONS-REMOTE-EXECUTION
and
found that it mentions that Immutable Functions and Operators can be pushed
down using `extensions` option for foreign server.

But it does not mention about TYPE. In the shippable.c
<https://doxygen.postgresql.org/shippable_8c_source.html>/lookup_shippable()
function, I found that type is also pushed down.

[image: image.png]

Does this require updating the docs? Can I raise a PR to do so? Thank you!
:)

-- 
Regards
Rajan Pandey


Attachments:

  [image/png] image.png (92.0K, 3-image.png)
  download | view image

^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* Re: Postgres_FDW doc doesn't specify TYPE support in Remote Execution Options
  2024-04-09 10:19 Postgres_FDW doc doesn't specify TYPE support in Remote Execution Options Rajan Pandey <[email protected]>
@ 2024-04-09 10:36 ` Laurenz Albe <[email protected]>
  0 siblings, 0 replies; 2+ messages in thread

From: Laurenz Albe @ 2024-04-09 10:36 UTC (permalink / raw)
  To: Rajan Pandey <[email protected]>; [email protected]

On Tue, 2024-04-09 at 15:49 +0530, Rajan Pandey wrote:
> I was reading https://www.postgresql.org/docs/current/postgres-fdw.html#POSTGRES-FDW-OPTIONS-REMOTE-EXECUTION
> and found that it mentions that Immutable Functions and Operators can
> be pushed down using `extensions` option for foreign server.
> 
> But it does not mention about TYPE. In the shippable.c/lookup_shippable()
> function, I found that type is also pushed down.

The comment only says that data types may be shippable, but not that
they are actually shipped.  Can you think of a case where a data type
would be shipped to a foreign server?  I wrote a foreign data wrapper,
and I cannot think of such a case.

Perhaps the function comment should be adjusted by removing the parenthesis
or changing it to "(operator/function/...)".

> Does this require updating the docs? Can I raise a PR to do so? Thank you! :) 

You would send a patch against the "master" branch to the pgsql-docs list for that.

Yours,
Laurenz Albe






^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2024-04-09 10:36 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2024-04-09 10:19 Postgres_FDW doc doesn't specify TYPE support in Remote Execution Options Rajan Pandey <[email protected]>
2024-04-09 10:36 ` Laurenz Albe <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox