From: Julien Rouhaud <rjuju123@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Sami Imseih <samimseih@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Christoph Berg <myon@debian.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: ma lz <ma100@hotmail.com>
Subject: Re: query_id: jumble names of temp tables for better pg_stat_statement UX
Date: Tue, 25 Mar 2025 13:28:39 +0800
Message-ID: <Z-I_BybOhD0RGRuC@jrouhaud> (raw)
In-Reply-To: <1207515.1742879842@sss.pgh.pa.us>
References: <461405.1742691859@sss.pgh.pa.us>
<Z9-sUvq8pE5uinEu@paquier.xyz>
<CAA5RZ0t4XQ_SANiJ5VfuoKnAuxMaY2ggQWoGKkHo+U2H+Sh-Sw@mail.gmail.com>
<1189112.1742869660@sss.pgh.pa.us>
<CAA5RZ0uNofEXfEfNw3uRN3D3oXkFPQ_s+huLLHMKR_+MCk8RPQ@mail.gmail.com>
<1192185.1742871390@sss.pgh.pa.us>
<CAA5RZ0vKpKEWcJn_UZkQVK=j1EUsXfASo06uWSqizzrwKMx8mQ@mail.gmail.com>
<1203118.1742877125@sss.pgh.pa.us>
<Z-I6c1Bbuo3uJWvw@jrouhaud>
<1207515.1742879842@sss.pgh.pa.us>
On Tue, Mar 25, 2025 at 01:17:22AM -0400, Tom Lane wrote:
> Julien Rouhaud <rjuju123@gmail.com> writes:
> > On Tue, Mar 25, 2025 at 12:32:05AM -0400, Tom Lane wrote:
> >> 2. Tools that are not entitled to set the value of the GUC are forced
> >> to be prepared to cope with any setting. That can be anywhere from
> >> painful to impossible.
>
> > Didn't that ship already sailed in pg14 when we allowed generating custom
> > query_id?
>
> Up to a point, perhaps. If I'm writing some kind of tool that digests
> pg_stat_statements results, I think I'm entitled to disregard the
> possibility that somebody is using a custom query_id that behaves in
> ways I'm not expecting --- or at least, fixing my code for that is
> their problem not mine. But it's much harder to take that attitude
> for things that are built into core PG.
I see, that's fair.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-general@postgresql.org
Cc: rjuju123@gmail.com, tgl@sss.pgh.pa.us, samimseih@gmail.com, michael@paquier.xyz, myon@debian.org, pgsql-hackers@lists.postgresql.org, ma100@hotmail.com
Subject: Re: query_id: jumble names of temp tables for better pg_stat_statement UX
In-Reply-To: <Z-I_BybOhD0RGRuC@jrouhaud>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox