public inbox for [email protected]  

help / color / mirror / Atom feed

From: Michael Paquier <[email protected]>
To: Tom Lane <[email protected]>
Cc: Laurenz Albe <[email protected]>
Cc: Dominique Devienne <[email protected]>
Cc: [email protected]
Subject: Re: Latest patches break one of our unit-test, related to RLS
Date: Tue, 16 Sep 2025 08:59:15 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <CAFCRh--M1y2YpJJMb6undzvyvhd4geKtRWFkDyr1shHvvoOkpQ@mail.gmail.com>
	<CAFCRh-_OBKtabe8MO0vUocNSq_O3_b852AXknPiNhL0tNUBGQg@mail.gmail.com>
	<CAFCRh-_U+8fmRoc-sYM5ahp=9dNjs=Dri1LFLcHCgEJX8Zq_oA@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>

On Sat, Sep 13, 2025 at 05:00:20PM -0400, Tom Lane wrote:
> Laurenz Albe <[email protected]> writes:
> > I came up with the attached patch set.
> 
> I did some more work on the comments, adjusted a couple of places that
> could be simplified, and pushed it.

My apologies for the silence here.

The timing of the events is interesting.  I have been pinged about
this issue on Friday evening/night time here:
https://www.postgresql.org/message-id/[email protected]

For a fix applied as of cdf7feb96562 roughly 24 hours after this ping.
The timing was a bit bad for me, because I was already gone for what
was a long weekend in Japan, just back today.  So it was a bit hard
for me to look at anything

> I didn't really love the "fix it and then explain it afterward"
> approach.  It's hard to review a patch if you don't understand the
> logic.  I considered swapping the order of the two patches, but
> eventually just merged them into one.

Merging both things makes sense as well here.

Ugh, yes.  That was wrong.  With the fix, '%' is translated:
-   Filter: (f1 ~ '^(?:[\a].*)$'::text)
Before the fix, not translated.
+   Filter: (f1 ~ '^(?:[\a]%)$'::text)

Thanks for the report, the analysis, and the commit.
--
Michael


Attachments:

  [application/pgp-signature] signature.asc (833B, 2-signature.asc)
  download

view thread (4+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Latest patches break one of our unit-test, related to RLS
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox