From: Martin Kalcher <martin.kalcher@aboutsource.net>
To: David G. Johnston <david.g.johnston@gmail.com>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Proposal to introduce a shuffle function to intarray extension
Date: Sun, 17 Jul 2022 11:54:22 +0200
Message-ID: <ceb243bc-dc71-6d19-866e-d30d066006bc@aboutsource.net> (raw)
In-Reply-To: <CAKFQuwaMZHx-9NcnBTQV9ObVQfPKixcYbEEPtkJGEdjn-RcxJg@mail.gmail.com>
References: <9d160a44-7675-51e8-60cf-6d64b76db831@aboutsource.net>
<CA+hUKGJFYY6s4nxDRz+PTLNYeUkZJJn_7+iMJoaQeRp5hKz0aQ@mail.gmail.com>
<b8f44b53-02d6-0be4-42df-cb6f737e6267@aboutsource.net>
<CAKFQuwaMZHx-9NcnBTQV9ObVQfPKixcYbEEPtkJGEdjn-RcxJg@mail.gmail.com>
Am 17.07.22 um 05:32 schrieb David G. Johnston:
>
> +SELECT sample('{1,2,3,4,5,6,7,8,9,10,11,12}', 6) !=
> sample('{1,2,3,4,5,6,7,8,9,10,11,12}', 6);
> + ?column?
> +----------
> + t
> +(1 row)
> +
>
> While small, there is a non-zero chance for both samples to be equal. This
> test should probably just go, I don't see what it tests that isn't covered
> by other tests or even trivial usage.
>
Hey David,
you are right. There is a small chance for this test to fail. I wanted
to test, that two invocations produce different results (after all the
main feature of the function). But it can probably go.
Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-general@postgresql.org
Cc: martin.kalcher@aboutsource.net, david.g.johnston@gmail.com, thomas.munro@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Proposal to introduce a shuffle function to intarray extension
In-Reply-To: <ceb243bc-dc71-6d19-866e-d30d066006bc@aboutsource.net>
References: <9d160a44-7675-51e8-60cf-6d64b76db831@aboutsource.net> <CA+hUKGJFYY6s4nxDRz+PTLNYeUkZJJn_7+iMJoaQeRp5hKz0aQ@mail.gmail.com> <b8f44b53-02d6-0be4-42df-cb6f737e6267@aboutsource.net> <CAKFQuwaMZHx-9NcnBTQV9ObVQfPKixcYbEEPtkJGEdjn-RcxJg@mail.gmail.com> <ceb243bc-dc71-6d19-866e-d30d066006bc@aboutsource.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox