pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Amit Kapila <amit.kapila@huawei.com>
To: 'Tom Lane' <tgl@sss.pgh.pa.us>
To: 'Heikki Linnakangas' <heikki.linnakangas@enterprisedb.com>
Cc: 'Robert Haas' <robertmhaas@gmail.com>
Cc: 'Fujii Masao' <masao.fujii@gmail.com>
Cc: 'Andres Freund' <andres@2ndquadrant.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: WAL format changes
Date: Tue, 26 Jun 2012 08:44:50 +0530
Message-ID: <001501cd5349$d9e82480$8db86d80$@kapila@huawei.com> (raw)
In-Reply-To: <8405.1340675505@sss.pgh.pa.us>
References: <4FDA5136.6080206@enterprisedb.com>
	<201206142358.12431.andres@2ndquadrant.com>
	<CA+TgmobG9VWWvLXeK0XOxoWXtza8JTFgSu2eoAtVFucxH6gLBw@mail.gmail.com>
	<4FDF6E8E.4080900@enterprisedb.com>
	<4FE034D0.5070900@enterprisedb.com>
	<CA+TgmoZu=UMKLJDQ5FNRqPnomiGOSdEvzaj_Gg9CJzcPnvuxgQ@mail.gmail.com>
	<4FE73F3F.5040105@enterprisedb.com>
	<CAHGQGwHpdpPrmbq49yOp=zZTsiB+_cnwojRh0Xe9BE1D8fLegg@mail.gmail.com>
	<CAHGQGwGZo-hv2Fxm3LpCsh=mh1T_21mj7MKe35VQyBSZ6PsyVw@mail.gmail.com>
	<CA+TgmoZz=7xRhg389Qj=SwdVCvpK4VSpjJm_yg7WKQuUpk0wjw@mail.gmail.com>
	<4FE8FDBE.8060901@enterprisedb.com>
	<8405.1340675505@sss.pgh.pa.us>

From: pgsql-hackers-owner@postgresql.org
[mailto:pgsql-hackers-owner@postgresql.org] On Behalf Of Tom Lane
Heikki Linnakangas <heikki.linnakangas@enterprisedb.com> writes:
>>  So I think we should change pg_resetxlog -l option to take a WAL file 
>>  name as argument, and fix pg_upgrade accordingly.

> Seems reasonable I guess.  It's really specifying a starting WAL
> location, but only to file granularity, so treating the argument as a
> file name is sort of a type cheat but seems convenient.

> If we do it that way, we'd better validate that the argument is a legal
> WAL file name, so as to catch any cases where somebody tries to do it
> old-style.

> BTW, does pg_resetxlog's logic for setting the default -l value (from
> scanning pg_xlog to find the largest existing file name) still work?
  

It finds the segment number for largest existing file name from pg_xlog and
then compare it with input provided by the 
user for -l Option, if input is greater it will use the input to set in
control file.
	
With Regards,
Amit Kapila.




view thread (31+ messages)  latest in thread

Message-ID: <001501cd5349$d9e82480$8db86d80$@kapila@huawei.com>
Permalink:  ../001501cd5349$d9e82480$8db86d80$@kapila@huawei.com/
Also on:    postgresql.org/message-id/001501cd5349$d9e82480$8db86d80$@kapila@huawei.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: amit.kapila@huawei.com, tgl@sss.pgh.pa.us, heikki.linnakangas@enterprisedb.com, robertmhaas@gmail.com, masao.fujii@gmail.com, andres@2ndquadrant.com
  Subject: Re: WAL format changes
  In-Reply-To: <001501cd5349$d9e82480$8db86d80$@kapila@huawei.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox