From: Andrey V. Lepikhov <a.lepikhov@postgrespro.ru>
To: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: pgsql-hackers@postgresql.org
Subject: Re: POC: postgres_fdw insert batching
Date: Fri, 10 Jul 2020 09:28:44 +0500
Message-ID: <0300d7df-854b-6f72-1e93-dfbf98f3fc8a@postgrespro.ru> (raw)
In-Reply-To: <20200628151002.7x5laxwpgvkyiu3q@development>
References: <20200628151002.7x5laxwpgvkyiu3q@development>
On 6/28/20 8:10 PM, Tomas Vondra wrote:
> Now, the primary reason why the performance degrades like this is that
> while FDW has batching for SELECT queries (i.e. we read larger chunks of
> data from the cursors), we don't have that for INSERTs (or other DML).
> Every time you insert a row, it has to go all the way down into the
> partition synchronously.
You added new fields into the PgFdwModifyState struct. Why you didn't
reused ResultRelInfo::ri_CopyMultiInsertBuffer field and
CopyMultiInsertBuffer machinery as storage for incoming tuples?
--
regards,
Andrey Lepikhov
Postgres Professional
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: a.lepikhov@postgrespro.ru, tomas.vondra@2ndquadrant.com
Subject: Re: POC: postgres_fdw insert batching
In-Reply-To: <0300d7df-854b-6f72-1e93-dfbf98f3fc8a@postgrespro.ru>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox