From: Jeff Davis <pgsql@j-davis.com>
To: Nathan Bossart <nathandbossart@gmail.com>
To: pgsql-hackers@postgresql.org
Subject: Re: un-revert the MAINTAIN privilege and the pg_maintain predefined role
Date: Wed, 13 Mar 2024 09:49:26 -0700
Message-ID: <031d60d1dcb869da4effe5e56411f8bdd01dd3a0.camel@j-davis.com> (raw)
In-Reply-To: <20240312210541.GA2400644@nathanxps13>
References: <20240305161235.GA3478007@nathanxps13>
<20240307165000.GA388645@nathanxps13>
<20240312210541.GA2400644@nathanxps13>
On Tue, 2024-03-12 at 16:05 -0500, Nathan Bossart wrote:
> It's easy enough to resolve this inconsistency by sending
> down the parent OID when recursing to a TOAST table and using that
> for the
> privilege checks. AFAICT this avoids any kind of cache lookup
> hazards
> because we hold a session lock on the main relation in this case.
> I've
> done this in the attached v2.
Looks good to me. Thank you for expanding on the comment, as well.
Regards,
Jeff Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pgsql@j-davis.com, nathandbossart@gmail.com
Subject: Re: un-revert the MAINTAIN privilege and the pg_maintain predefined role
In-Reply-To: <031d60d1dcb869da4effe5e56411f8bdd01dd3a0.camel@j-davis.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox