From: Andrew Dunstan <andrew@dunslane.net>
To: Amit Langote <amitlangote09@gmail.com>
To: David Rowley <dgrowleyml@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Andres Freund <andres@anarazel.de>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: John Naylor <john.naylor@enterprisedb.com>
Cc: Jonathan S. Katz <jkatz@postgresql.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Cc: Nikita Glukhov <n.gluhov@postgrespro.ru>
Subject: Re: PG 15 (and to a smaller degree 14) regression due to ExprEvalStep size
Date: Fri, 29 Jul 2022 14:27:36 -0400
Message-ID: <035bfc05-d6ea-b746-ce80-a533b41a0d55@dunslane.net> (raw)
In-Reply-To: <CA+HiwqEp=vF=0=tUPYz2N3OOp+19CgCrNBgLUUK7SWec_YZ5UQ@mail.gmail.com>
References: <CA+HiwqHS3LSmWpjdCfq2cdB2W--=0ETHmQPF8bXCY2Mn=bXBog@mail.gmail.com>
<20220721171235.7okm3q5i7jyuwtqw@alvherre.pgsql>
<CA+HiwqENocTzGwbzdLrc7CwTW4qivkFRhSvWKi7Ph77s=85aTg@mail.gmail.com>
<CAApHDvr_DPoAfe2jAyP5rd=h+Z0-WZxeEB025=Fvw7JRbeWDOA@mail.gmail.com>
<CA+HiwqFyNvVYSegZw5pWTSAi1EtZLBtAexP2APqgOOcGLn_31g@mail.gmail.com>
<CA+HiwqEp=vF=0=tUPYz2N3OOp+19CgCrNBgLUUK7SWec_YZ5UQ@mail.gmail.com>
On 2022-07-27 We 04:01, Amit Langote wrote:
> On Fri, Jul 22, 2022 at 2:49 PM Amit Langote <amitlangote09@gmail.com> wrote:
>> On Fri, Jul 22, 2022 at 1:13 PM David Rowley <dgrowleyml@gmail.com> wrote:
>>> BTW, I was working on code inside llvm_compile_expr() a few days ago
>>> and I thought I'd gotten the new evaluation steps I was adding correct
>>> as it worked fine with jit_above_cost=0, but on further testing, it
>>> crashed with jit_inline_above_cost=0. Might be worth doing both to see
>>> if everything works as intended.
>> Thanks for the pointer.
>>
>> So I didn't see things going bust on re-testing with all
>> jit_*_above_cost parameters set to 0, so maybe the
>> llvm_compile_expression() additions are alright.
> Here's an updated version of the patch, with mostly cosmetic changes.
> In particular, I added comments describing the new llvm_compile_expr()
> blobs.
>
Andres,
this work has been done in response to a complaint from you. Does this
address your concerns satisfactorily?
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: andrew@dunslane.net, amitlangote09@gmail.com, dgrowleyml@gmail.com, alvherre@alvh.no-ip.org, andres@anarazel.de, michael@paquier.xyz, john.naylor@enterprisedb.com, jkatz@postgresql.org, tgl@sss.pgh.pa.us, pg@bowt.ie, n.gluhov@postgrespro.ru
Subject: Re: PG 15 (and to a smaller degree 14) regression due to ExprEvalStep size
In-Reply-To: <035bfc05-d6ea-b746-ce80-a533b41a0d55@dunslane.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox