From: Vik Fearing <vik.fearing@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Gierth <andrew@tao11.riddles.org.uk>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Fix for FETCH FIRST syntax problems
Date: Sun, 20 May 2018 01:27:30 +0200
Message-ID: <03da97fc-9d6b-cbe1-c28f-cee7c1ba5c38@2ndquadrant.com> (raw)
In-Reply-To: <22981.1526770675@sss.pgh.pa.us>
References: <877enz476l.fsf@news-spur.riddles.org.uk>
<22981.1526770675@sss.pgh.pa.us>
On 20/05/18 00:57, Tom Lane wrote:
> Andrew Gierth <andrew@tao11.riddles.org.uk> writes:
>> Attached is a draft patch for fixing that, which additionally fixes the
>> ugly wart that OFFSET <x> ROW/ROWS and FETCH FIRST [<x>] ROW/ROWS ONLY
>> had very different productions for <x>; both now accept c_expr there.
>
> LGTM, except please s/presense/presence/ in grammar comment.
> Also, why'd you back off "must write" to "should write" in the docs?
> This doesn't make the parens any more optional than before.
It certainly does. It allows this now:
PREPARE foo AS TABLE bar FETCH FIRST $1 ROWS ONLY;
>> I think a case can be made that this should be backpatched; thoughts?
>
> Meh, -0.5. This is not really a bug, because it's operating as designed.
> You've found a reasonably painless way to improve the grammar, which is
> great, but it seems more like a feature addition than a bug fix.
>
> I'd be fine with sneaking this into v11, though.
I'm +1 for backpatching it. It may be operating as designed by PeterE
ten years ago, but it's not operating as designed by the SQL standard.
--
Vik Fearing +33 6 46 75 15 36
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: vik.fearing@2ndquadrant.com, tgl@sss.pgh.pa.us, andrew@tao11.riddles.org.uk
Subject: Re: Fix for FETCH FIRST syntax problems
In-Reply-To: <03da97fc-9d6b-cbe1-c28f-cee7c1ba5c38@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox