pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Domains and arrays and composites, oh my
Date: Thu, 28 Sep 2017 14:58:00 -0400
Message-ID: <044f3a1c-9e20-c08b-8f78-c47aa41d7a0c@2ndQuadrant.com> (raw)
In-Reply-To: <32440.1506618167@sss.pgh.pa.us>
References: <4206.1499798337@sss.pgh.pa.us>
	<12364.1499973554@sss.pgh.pa.us>
	<aaaa73ea-4d5f-ed8c-7222-06a2d5f2891e@2ndQuadrant.com>
	<32440.1506618167@sss.pgh.pa.us>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>



On 09/28/2017 01:02 PM, Tom Lane wrote:
>
>> I do think that treating a function returning a domain-over-composite
>> differently from one returning a base composite is a POLA. We'd be very
>> hard put to explain the reasons for it to an end user.
> Do you have any thoughts about how we ought to resolve that?
>
>


Not offhand. Maybe we need to revisit the decision not to modify the
executor at all. Obviously that would make the patch a good deal more
invasive ;-(  One thought I had was that we could invent a new return
type of TYPEFUNC_DOMAIN_COMPOSITE so there would be less danger of a PL
just treating it as an unconstrained base type as it might do if it saw
TYPEFUNC_COMPOSITE.

Maybe I'm wrong, but I have a strong suspicion that of we leave it like
this now we'll regret it in the future.

cheers

andrew

-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (11+ messages)  latest in thread

Message-ID: <044f3a1c-9e20-c08b-8f78-c47aa41d7a0c@2ndQuadrant.com>
Permalink:  ../044f3a1c-9e20-c08b-8f78-c47aa41d7a0c@2ndQuadrant.com/
Also on:    postgresql.org/message-id/044f3a1c-9e20-c08b-8f78-c47aa41d7a0c@2ndQuadrant.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: andrew.dunstan@2ndquadrant.com, tgl@sss.pgh.pa.us
  Subject: Re: Domains and arrays and composites, oh my
  In-Reply-To: <044f3a1c-9e20-c08b-8f78-c47aa41d7a0c@2ndQuadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox