pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tomas Vondra <tomas.vondra@enterprisedb.com>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Dean Rasheed <dean.a.rasheed@gmail.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: PoC/WIP: Extended statistics on expressions
Date: Fri, 22 Jan 2021 14:09:04 +0100
Message-ID: <04b100f9-201b-0bc8-c613-0f918451b599@enterprisedb.com> (raw)
In-Reply-To: <20210122040101.GF27167@telsasoft.com>
References: <5305f9cf-3927-06c4-cd5b-e46cbc58bc7f@enterprisedb.com>
	<20210116232208.GB8560@telsasoft.com>
	<2f2a3b3b-93e4-723f-144e-bc21f10d6b61@enterprisedb.com>
	<20210118045331.GF8560@telsasoft.com>
	<CAEZATCVnQccV_Z7AuvbvquaOYxUj+cVFk48pPGASYHFjXWgW5g@mail.gmail.com>
	<3f20da4d-89dc-0912-98d2-b6f0ef06c87f@enterprisedb.com>
	<CAEZATCUuj5FPjtOU2=7Z2pTC8LEvrf79+Go7R8yQ+eE0ezfgfQ@mail.gmail.com>
	<f865af90-c19c-769e-8c65-19692e245479@enterprisedb.com>
	<20210122022958.GC27167@telsasoft.com>
	<acf27932-8159-8872-8fca-902c7a35b351@enterprisedb.com>
	<20210122040101.GF27167@telsasoft.com>



On 1/22/21 5:01 AM, Justin Pryzby wrote:
> On Fri, Jan 22, 2021 at 04:49:51AM +0100, Tomas Vondra wrote:
>>>> | Statistics objects:
>>>> |     "public"."s2" (ndistinct, dependencies, mcv) ON  FROM t
>>
>> Umm, for me that prints:
> 
>>      "public"."s2" ON ((i + 1)), (((i + 1) + 0)) FROM t
>>
>> which I think is OK. But maybe there's something else to trigger the
>> problem?
> 
> Oh.  It's because I was using /usr/bin/psql and not ./src/bin/psql.
> I think it's considered ok if old client's \d commands don't work on new
> server, but it's not clear to me if it's ok if they misbehave.  It's almost
> better it made an ERROR.
> 

Well, how would the server know to throw an error? We can't quite patch 
the old psql (if we could, we could just tweak the query).

> In any case, why are there so many parentheses ?
> 

That's a bug in pg_get_statisticsobj_worker, probably. It shouldn't be 
adding extra parentheses, on top of what deparse_expression_pretty does. 
Will fix.


regards

-- 
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company





view thread (107+ messages)  latest in thread

Message-ID: <04b100f9-201b-0bc8-c613-0f918451b599@enterprisedb.com>
Permalink:  ../04b100f9-201b-0bc8-c613-0f918451b599@enterprisedb.com/
Also on:    postgresql.org/message-id/04b100f9-201b-0bc8-c613-0f918451b599@enterprisedb.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tomas.vondra@enterprisedb.com, pryzby@telsasoft.com, dean.a.rasheed@gmail.com
  Subject: Re: PoC/WIP: Extended statistics on expressions
  In-Reply-To: <04b100f9-201b-0bc8-c613-0f918451b599@enterprisedb.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox