From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Robert Haas <robertmhaas@gmail.com>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: cleaning perl code
Date: Thu, 9 Apr 2020 20:26:45 +0200
Message-ID: <053dce96-107b-b73f-fe15-91aaf3c0c3a7@2ndquadrant.com> (raw)
In-Reply-To: <CA+Tgmoa0VjL+qmrJakQKA8+eyBNopVz=vBEDe9Sh3Hpp+-e6_g@mail.gmail.com>
References: <e56f6fb6-38d5-8450-577c-24eb5d63f2e1@2ndQuadrant.com>
<CA+Tgmoa0VjL+qmrJakQKA8+eyBNopVz=vBEDe9Sh3Hpp+-e6_g@mail.gmail.com>
On 2020-04-09 19:47, Robert Haas wrote:
> On Thu, Apr 9, 2020 at 11:44 AM Andrew Dunstan
> <andrew.dunstan@2ndquadrant.com> wrote:
>> We currently only run perlcritic at severity level 5, which is fairly
>> permissive. I'd like to reduce that, ideally to, say, level 3, which is
>> what I use for the buildfarm code.
>>
>> But let's start by going to severity level 4.
>
> I continue to be skeptical of perlcritic. I think it complains about a
> lot of things which don't matter very much. We should consider whether
> the effort it takes to keep it warning-clean has proportionate
> benefits.
Let's see what the patches look like. At least some of the warnings
look reasonable, especially in the sense that they are things casual
Perl programmers might accidentally do wrong.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, robertmhaas@gmail.com, andrew.dunstan@2ndquadrant.com
Subject: Re: cleaning perl code
In-Reply-To: <053dce96-107b-b73f-fe15-91aaf3c0c3a7@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox