public inbox for [email protected]  

help / color / mirror / Atom feed

From: Alexander Lakhin <[email protected]>
To: Ranier Vilela <[email protected]>
To: Pg Hackers <[email protected]>
Subject: Re: Avoid unused value (src/fe_utils/print.c)
Date: Sat, 3 Jun 2023 15:00:01 +0300
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAEudQAqwC5=cwgyEhq6HZS6aF_2QB_DMTm0j2qfmQnPwgPVKdw@mail.gmail.com>
References: <CAEudQAqwC5=cwgyEhq6HZS6aF_2QB_DMTm0j2qfmQnPwgPVKdw@mail.gmail.com>

Hello Ranier,

03.06.2023 13:14, Ranier Vilela wrote:
> Hi,
>
> This is for Postgres 17 (head).
>
> Per Coverity.
> At function print_unaligned_text, variable "need_recordsep", is
> unnecessarily set to true and false.

Clang' scan-build detects 58 errors "Dead assignment", including that one.
Maybe it would be more sensible to eliminate all errors of this class?

Best regards,
Alexander

view thread (3+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Avoid unused value (src/fe_utils/print.c)
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox