pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: David Rowley <dgrowleyml@gmail.com>
Cc: Edmund Horner <ejrh00@gmail.com>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Tid scan improvements
Date: Mon, 7 Jun 2021 12:11:53 +0200
Message-ID: <05b070ee-b68c-56ca-be41-aa240ee62d81@enterprisedb.com> (raw)
In-Reply-To: <CAApHDvrxaKMBrV-Tr3ogLaNJMSPC7_GGQWprsDg+HA3Ky0=m=g@mail.gmail.com>
References: <CAMyN-kCX8kNy85_Sa-=gXNhZL84vbDtxpKPTF7qTDtTwykaOEQ@mail.gmail.com>
	<20191201023416.GV2355@paquier.xyz>
	<20210101013019.GS13234@fetter.org>
	<CAMyN-kCv4ekxAJDFM7H3yjNpcxr9OPSY3C=yrFODDSdL4vctww@mail.gmail.com>
	<CAApHDvqZcqVgWy1nY6xnQpVExtfx=DSKCdXbBxT_b5hQOgu2dA@mail.gmail.com>
	<CAApHDvozoYzeBqzVss_oh5HUFFSMZ2afmQQka-wH4xHU2LUE1w@mail.gmail.com>
	<20210203211919.u7q3vq24g4pd63gv@alap3.anarazel.de>
	<CAApHDvqDcx3_CM1Y4hiCv7q3o3iLFsF1g=SQ5B=6NJoSPEDA_Q@mail.gmail.com>
	<CAApHDvrdoop-9ojBMLX0x_xa0=6v_trhXM8soAwSb5yebaWPgg@mail.gmail.com>
	<CAApHDvor_H6qRrCHXpQKODZaS7L1hU5ogyBGGx3cxLiNgiDhdw@mail.gmail.com>
	<20210216220522.3sn64ui3prwm43zh@alap3.anarazel.de>
	<CAApHDvqfLgx4xaYcJg3wgnW-fe2B-qLUKt00rkPz7QMunQL6+A@mail.gmail.com>
	<CAApHDvqoO33Em0tWoJvwN2cqvAJ45nB+qqfS5cxLbQ45BGPwkg@mail.gmail.com>
	<CAApHDvrxaKMBrV-Tr3ogLaNJMSPC7_GGQWprsDg+HA3Ky0=m=g@mail.gmail.com>

This patch didn't add _outTidRangePath() even though we have outNode() 
coverage for most/all path nodes.  Was this just forgotten?  See 
attached patch.

Attachments:


0001-Add-_outTidRangePath.patch (text/plain, 1.2K) download
From 3c696f812d4c6f8c66bc75105c3c1af79c3b2922 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut <peter@eisentraut.org>
Date: Mon, 7 Jun 2021 12:04:49 +0200
Subject: [PATCH] Add _outTidRangePath()

We have outNode() coverage for all path nodes, but this one was
missed when it was added.
---
 src/backend/nodes/outfuncs.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/src/backend/nodes/outfuncs.c b/src/backend/nodes/outfuncs.c
index 04696f613c..e32b92e299 100644
--- a/src/backend/nodes/outfuncs.c
+++ b/src/backend/nodes/outfuncs.c
@@ -1859,6 +1859,16 @@ _outTidPath(StringInfo str, const TidPath *node)
 	WRITE_NODE_FIELD(tidquals);
 }
 
+static void
+_outTidRangePath(StringInfo str, const TidRangePath *node)
+{
+	WRITE_NODE_TYPE("TIDRANGEPATH");
+
+	_outPathInfo(str, (const Path *) node);
+
+	WRITE_NODE_FIELD(tidrangequals);
+}
+
 static void
 _outSubqueryScanPath(StringInfo str, const SubqueryScanPath *node)
 {
@@ -4166,6 +4176,9 @@ outNode(StringInfo str, const void *obj)
 			case T_TidPath:
 				_outTidPath(str, obj);
 				break;
+			case T_TidRangePath:
+				_outTidRangePath(str, obj);
+				break;
 			case T_SubqueryScanPath:
 				_outSubqueryScanPath(str, obj);
 				break;
-- 
2.31.1



view thread (97+ messages)  latest in thread

Message-ID: <05b070ee-b68c-56ca-be41-aa240ee62d81@enterprisedb.com>
Permalink:  ../05b070ee-b68c-56ca-be41-aa240ee62d81@enterprisedb.com/
Also on:    postgresql.org/message-id/05b070ee-b68c-56ca-be41-aa240ee62d81@enterprisedb.com

 ·  · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: peter.eisentraut@enterprisedb.com, dgrowleyml@gmail.com, ejrh00@gmail.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: Tid scan improvements
  In-Reply-To: <05b070ee-b68c-56ca-be41-aa240ee62d81@enterprisedb.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox