pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Julien Rouhaud <rjuju123@gmail.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: Dilip Kumar <dilipbalaut@gmail.com>
Cc: Kuntal Ghosh <kuntalghosh.2007@gmail.com>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Kirill Bychik <kirill.bychik@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: Thomas Munro <thomas.munro@gmail.com>
Subject: Re: WAL usage calculation patch
Date: Thu, 23 Apr 2020 08:46:50 +0200
Message-ID: <05bdb944-e12b-232a-41c0-e78cc9e63d17@2ndquadrant.com> (raw)
In-Reply-To: <CAOBaU_bUGhaXB0Q00FGtowjXgbPGOAcn6CxjY5zXSeT4ZuWkAA@mail.gmail.com>
References: <CAOBaU_ZbVMGta+1OkTn3qsPd=myi9cgv1hQFpdrQZdhDOjq8PA@mail.gmail.com>
	<20200418204105.GL26953@telsasoft.com>
	<CAOBaU_Z5dK=cMXTaEEgXNCY7GrsBnVfk4vwK2h7o+2Aowb33Qw@mail.gmail.com>
	<20200420.164656.881770765734654652.horikyota.ntt@gmail.com>
	<CAA4eK1JjkkmTcZFa1taS0uUpPM3KeYb_oJd0ak8QchsAs29eFg@mail.gmail.com>
	<20200422035501.GN3890@telsasoft.com>
	<CAA4eK1Kg4Tup076MtbzJkp9vTp=f9orkVaDgtLSnwC_GF1YRSg@mail.gmail.com>
	<CAOBaU_bUGhaXB0Q00FGtowjXgbPGOAcn6CxjY5zXSeT4ZuWkAA@mail.gmail.com>

On 2020-04-23 07:31, Julien Rouhaud wrote:
> I agree that full page writes can be used in this case, but I'm
> wondering if that can be misleading for some reader which might e.g.
> confuse with the full_page_writes GUC.  And as Justin pointed out, the
> documentation for now usually mentions "full page image(s)" in such
> cases.

ISTM that in the context of this patch, "full-page image" is correct.  A 
"full-page write" is what you do to a table or index page when you are 
recovering a full-page image.  The internal symbol for the WAL record is 
XLOG_FPI and xlogdesc.c prints it as "FPI".

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services





view thread (130+ messages)  latest in thread

Message-ID: <05bdb944-e12b-232a-41c0-e78cc9e63d17@2ndquadrant.com>
Permalink:  ../05bdb944-e12b-232a-41c0-e78cc9e63d17@2ndquadrant.com/
Also on:    postgresql.org/message-id/05bdb944-e12b-232a-41c0-e78cc9e63d17@2ndquadrant.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: peter.eisentraut@2ndquadrant.com, rjuju123@gmail.com, amit.kapila16@gmail.com, pryzby@telsasoft.com, horikyota.ntt@gmail.com, dilipbalaut@gmail.com, kuntalghosh.2007@gmail.com, masao.fujii@oss.nttdata.com, kirill.bychik@gmail.com, thomas.munro@gmail.com
  Subject: Re: WAL usage calculation patch
  In-Reply-To: <05bdb944-e12b-232a-41c0-e78cc9e63d17@2ndquadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox