public inbox for [email protected]  
help / color / mirror / Atom feed
From: Zhang Mingli <[email protected]>
To: Álvaro Herrera <[email protected]>
Cc: Michael Paquier <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Proposal to CREATE FOREIGN TABLE LIKE
Date: Thu, 6 Feb 2025 20:13:47 +0800
Message-ID: <0663eec9-883d-4c25-ade4-58f227ece827@Spark> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

On Feb 6, 2025 at 18:31 +0800, Álvaro Herrera <[email protected]>, wrote:
>
> Ah, but our fine manual already says
>
> The LIKE clause can also be used to copy column definitions from views,
> foreign tables, or composite types. Inapplicable options (e.g.,
> INCLUDING INDEXES from a view) are ignored.
>
> so what you implemented seems to be okay from that POV.
Hi, Yeah,

Our current convention is to ignore any inapplicable options without throwing errors.

As you mentioned, we use bits to identify the options, which does add some complexity to the codes if we try to track the origin of the option bits.

--
Zhang Mingli
HashData


view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Proposal to CREATE FOREIGN TABLE LIKE
  In-Reply-To: <0663eec9-883d-4c25-ade4-58f227ece827@Spark>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox