From: Andreas Karlsson <andreas@proxel.se>
To: Christoph Berg <myon@debian.org>
To: Heikki Linnakangas <hlinnaka@iki.fi>
To: Michael Paquier <michael.paquier@gmail.com>
To: Victor Wagner <vitus@wagner.pp.ru>
To: pgsql-hackers@postgresql.org, Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Subject: Re: OpenSSL 1.1 breaks configure and more
Date: Sat, 17 Sep 2016 11:39:35 +0200
Message-ID: <074eabb9-c2f8-b889-be75-91e936b9a297@proxel.se> (raw)
In-Reply-To: <20160916141106.kr535occwxlmdasg@msg.df7cb.de>
References: <20160916141106.kr535occwxlmdasg@msg.df7cb.de>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
On 09/16/2016 04:11 PM, Christoph Berg wrote:
> Thanks for the patch!
>
> I just tried to apply it to 9.2. There was a conflict in configure.in which was
> trivial to resolve.
>
> Another conflict in contrib/pgcrypto/pgcrypto.c was not applicable
> because the code doesn't seem to exist (didn't try very hard though).
>
> Ignoring the contrib conflict, it still didn't compile:
>
> /home/cbe/projects/postgresql/debian/9.2/build/../src/backend/libpq/be-secure.c: In function ‘secure_write’:
> /home/cbe/projects/postgresql/debian/9.2/build/../src/backend/libpq/be-secure.c:342:17: error: dereferencing pointer to incomplete type ‘SSL {aka struct ssl_st}’
> if (port->ssl->state != SSL_ST_OK)
> ^~
> /home/cbe/projects/postgresql/debian/9.2/build/../src/backend/libpq/be-secure.c:342:28: error: ‘SSL_ST_OK’ undeclared (first use in this function)
> if (port->ssl->state != SSL_ST_OK)
> ^~~~~~~~~
This is related to the renegotiation which was first fixed and later
removed in the 9.4 cycle, but intentionally not backported. It seems
like OpenSSL refactored the state machine in 1.1 which is why the code
above breaks.
I am not entirely sure I follow what the old code in 9.3 and 9.2 is
strying to do and why it messes directly with the state of the statemachine.
Andreas
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: andreas@proxel.se, myon@debian.org, hlinnaka@iki.fi, michael.paquier@gmail.com, vitus@wagner.pp.ru, tgl@sss.pgh.pa.us, alvherre@2ndquadrant.com
Subject: Re: OpenSSL 1.1 breaks configure and more
In-Reply-To: <074eabb9-c2f8-b889-be75-91e936b9a297@proxel.se>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox