From: Mark Dilger <hornschnorter@gmail.com>
To: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Adrien Nayrat <adrien.nayrat@dalibo.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: [HACKERS] PATCH: multivariate histograms and MCV lists
Date: Sat, 25 Nov 2017 08:15:05 -0800
Message-ID: <0895FFB4-DEB7-459B-ABD2-E7855D0291A8@gmail.com> (raw)
In-Reply-To: <cf43d6de-617f-83c0-8c14-740c3fa23795@2ndquadrant.com>
References: <dfdac334-9cf2-2597-fb27-f0fb3753f435@2ndquadrant.com>
<31ee8686-6d62-7f10-4129-7580ec74a710@dalibo.com>
<b3688203-7c5d-2d7e-58b6-a6bb04f29b5c@2ndquadrant.com>
<340ffd44-2d67-d39d-e54f-5a97a842cd3a@2ndquadrant.com>
<b3e23e18-afbb-2a39-8e15-fe0a6c39a128@2ndquadrant.com>
<67EAB5B3-F9FB-4753-8102-4D77DCFFFCD4@gmail.com>
<cf43d6de-617f-83c0-8c14-740c3fa23795@2ndquadrant.com>
> On Nov 18, 2017, at 12:28 PM, Tomas Vondra <tomas.vondra@2ndquadrant.com> wrote:
>
> Hi,
>
> Attached is an updated version of the patch, adopting the psql describe
> changes introduced by 471d55859c11b.
>
> regards
>
> --
> Tomas Vondra http://www.2ndQuadrant.com
> PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
> <0001-multivariate-MCV-lists.patch.gz><0002-multivariate-histograms.patch.gz>
Thanks, Tomas, again for your work on this feature.
Applying just the 0001-multivariate-MCV-lists.patch to the current master, and
then extending the stats_ext.sql test as follows, I am able to trigger an error,
"ERROR: operator 4294934272 is not a valid ordering operator".
diff --git a/src/test/regress/sql/stats_ext.sql b/src/test/regress/sql/stats_ext.sqlindex e9902ced5c..5083dc05e6 100644--- a/src/test/regress/sql/stats_ext.sql+++ b/src/test/regress/sql/stats_ext.sql@@ -402,4 +402,22 @@ EXPLAIN (COSTS OFF)
EXPLAIN (COSTS OFF)
SELECT * FROM mcv_lists WHERE a IS NULL AND b IS NULL AND c IS NULL;
-RESET random_page_cost;+DROP TABLE mcv_lists; + +CREATE TABLE mcv_lists (+ a NUMERIC[],+ b NUMERIC[]+);+CREATE STATISTICS mcv_lists_stats (mcv) ON a, b FROM mcv_lists;+INSERT INTO mcv_lists (a, b)+ (SELECT array_agg(gs::numeric) AS a, array_agg(gs::numeric) AS b+ FROM generate_series(1,1000) gs+ );+ANALYZE mcv_lists;+INSERT INTO mcv_lists (a, b)+ (SELECT array_agg(gs::numeric) AS a, array_agg(gs::numeric) AS b+ FROM generate_series(1,1000) gs+ );+ANALYZE mcv_lists;++DROP TABLE mcv_lists;
Which gives me the following regression.diffs:
*** /Users/mark/master/postgresql/src/test/regress/expected/stats_ext.out 2017-11-25 08:06:37.000000000 -0800
--- /Users/mark/master/postgresql/src/test/regress/results/stats_ext.out 2017-11-25 08:10:18.000000000 -0800
***************
*** 721,724 ****
Index Cond: ((a IS NULL) AND (b IS NULL))
(5 rows)
! RESET random_page_cost;
--- 721,741 ----
Index Cond: ((a IS NULL) AND (b IS NULL))
(5 rows)
! DROP TABLE mcv_lists;
! CREATE TABLE mcv_lists (
! a NUMERIC[],
! b NUMERIC[]
! );
! CREATE STATISTICS mcv_lists_stats (mcv) ON a, b FROM mcv_lists;
! INSERT INTO mcv_lists (a, b)
! (SELECT array_agg(gs::numeric) AS a, array_agg(gs::numeric) AS b
! FROM generate_series(1,1000) gs
! );
! ANALYZE mcv_lists;
! INSERT INTO mcv_lists (a, b)
! (SELECT array_agg(gs::numeric) AS a, array_agg(gs::numeric) AS b
! FROM generate_series(1,1000) gs
! );
! ANALYZE mcv_lists;
! ERROR: operator 4294934272 is not a valid ordering operator
! DROP TABLE mcv_lists;
======================================================================
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: hornschnorter@gmail.com, tomas.vondra@2ndquadrant.com, adrien.nayrat@dalibo.com
Subject: Re: [HACKERS] PATCH: multivariate histograms and MCV lists
In-Reply-To: <0895FFB4-DEB7-459B-ABD2-E7855D0291A8@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox