pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
To: Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Simon Riggs <simon@2ndquadrant.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Partitioned tables and relfilenode
Date: Tue, 28 Feb 2017 14:03:12 +0900
Message-ID: <098044f4-24ef-e7db-a0fc-47f1d2014232@lab.ntt.co.jp> (raw)
In-Reply-To: <CAFjFpRd3WJGa0ZRcMWaw4Mt1oak1MzWkN-T=+VkxQeRKVUvjLA@mail.gmail.com>
References: <2b0d42f2-3a53-763b-c9c2-47139e4b1c2e@lab.ntt.co.jp>
	<CANP8+jL+tA9kB3hNkttU-X4VOm=tJB=gfVjf+p4+6xvk8XRjXQ@mail.gmail.com>
	<CA+TgmoY8SPNC2Zz2fVt-8vOwps4Ur3QdXh=2UmHSKbKMJeOOrw@mail.gmail.com>
	<38d14945-b84c-0769-da36-b1f67c65395d@lab.ntt.co.jp>
	<CA+TgmoYvpz=LsPtfdXUahJ4VKRLpma9KL_tqRsrpzVFvY7ATJw@mail.gmail.com>
	<a3aef18d-ce05-2163-30e3-d1f9154cc076@lab.ntt.co.jp>
	<CAFjFpRdMvMD3hMYw67pC23_ncD=ONLX1LRi8MEdvsco+=09-3A@mail.gmail.com>
	<9be09bd2-6cda-f68a-5992-8e8e53a56f51@lab.ntt.co.jp>
	<CAFjFpRfD-bh=3iO+4Vu7CRQbe+5AAJTqyckeQDOR8ymj-UPLkg@mail.gmail.com>
	<a34313a6-6a50-4690-79f6-0691bb87db83@lab.ntt.co.jp>
	<CA+TgmoY4q_oGaPqaFSb5ZDPCpaisU=+F0BzqAgy0e4aTxvT0og@mail.gmail.com>
	<CAFjFpRd3WJGa0ZRcMWaw4Mt1oak1MzWkN-T=+VkxQeRKVUvjLA@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

On 2017/02/28 13:52, Ashutosh Bapat wrote:
> Amit's original patch had an assertion failure in
> extract_autovac_opts(). His patch adds partitioned tables in the list
> of tables to be auto-analyzed. But there's an assertion in
> extract_autovac_opts(), which did not consider partitioned tables.
> When a partitioned table is created, the assertion trips in autovacuum
> worker and resets the cluster, restarting all the backends. I have
> updated Robert's patch with the assertion fixed.

Since Robert's patch backed out all autovacuum.c changes, partitioned
tables case would no longer be able to reach that Assert.

Thanks,
Amit




-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (96+ messages)  latest in thread

Message-ID: <098044f4-24ef-e7db-a0fc-47f1d2014232@lab.ntt.co.jp>
Permalink:  ../098044f4-24ef-e7db-a0fc-47f1d2014232@lab.ntt.co.jp/
Also on:    postgresql.org/message-id/098044f4-24ef-e7db-a0fc-47f1d2014232@lab.ntt.co.jp

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: Langote_Amit_f8@lab.ntt.co.jp, ashutosh.bapat@enterprisedb.com, robertmhaas@gmail.com, simon@2ndquadrant.com
  Subject: Re: Partitioned tables and relfilenode
  In-Reply-To: <098044f4-24ef-e7db-a0fc-47f1d2014232@lab.ntt.co.jp>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox