public inbox for [email protected]  

help / color / mirror / Atom feed

From: Chao Li <[email protected]>
To: Ayush Tiwari <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: Ashutosh Bapat <[email protected]>
Subject: Re: [PATCH] Clean up property graph error messages
Date: Tue, 5 May 2026 10:50:09 +0800
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAJTYsWXFy1j_T82+M_S9kFxU414tQYnZQD-b82=oL_LbG_5fPQ@mail.gmail.com>
References: <CAJTYsWXFy1j_T82+M_S9kFxU414tQYnZQD-b82=oL_LbG_5fPQ@mail.gmail.com>



> On May 5, 2026, at 03:57, Ayush Tiwari <[email protected]> wrote:
> 
> Hi,
> 
> While looking at the SQL/PGQ property graph error paths, I noticed a
> few small cleanups in propgraphcmds.c.
> 
> The attached patch fixes a user-visible error message from "mismatching
> properties names" to "mismatching property names”,

I think changing “properties names” to “property names” is correct.

I wonder if we can also change “mismatching” to “mismatched”, so the error message is:
```
"mismatched property names in definition of label \"%s\""
```


> and moves a
> ReleaseSysCache() call before an ERROR ereport in
> check_element_properties().  
> 
> The existing code should be cleaned up by
> the resource owner on the ERROR path, but the explicit ReleaseSysCache()
> placed after ereport(ERROR) was unreachable.
> 

Agreed.


> The regression expected output is updated for the changed error text.
> 
> [On a separate note, it might be better to change all "vertexes" to "vertices",
> haven't included that in the patch though since the other one is not exactly
> wrong?]
> 
> Regards,
> Ayus
> <v1-0001-Clean-up-property-graph-error-messages.patch>

So, v1 LGTM. Only thing is that I think we can also make “mismatching” to “mismatched” in the errmsg.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

view thread (9+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] Clean up property graph error messages
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox