public inbox for [email protected]  

help / color / mirror / Atom feed

From: Andreas Karlsson <[email protected]>
To: William Bernbaum <[email protected]>
To: [email protected] <[email protected]>
Subject: Re: [PATCH] Fix pg_dump emitting OVERRIDING SYSTEM VALUE for tables with dropped identity columns
Date: Fri, 1 May 2026 09:39:07 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <PH0PR18MB44430C10F7431F8D163CDAFFA6202@PH0PR18MB4443.namprd18.prod.outlook.com>
	<[email protected]>

On 5/1/26 09:28, Andreas Karlsson wrote:
> On 4/18/26 01:29, William Bernbaum wrote:
>> Patch attached.

Forgot this: Maybe it is just a bit too early in the morning and I have 
not had coffee yet but I struggled a bit to apply your patch. A 
recommendation for making patches easy to apply for other developers is 
to generate them with the "git format-patch" command which makes them 
easy to apply with "git am". You can use the "-v" flag to "git 
format-patch" if you want to add a version number to the generated file 
names.
Also another question worth looking into is if this same bug affects 
other things, e.g. the setting of hasdefaults.

Thanks again for the patch!

--
Andreas Karlsson
Percona

view thread (3+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] Fix pg_dump emitting OVERRIDING SYSTEM VALUE for tables with dropped identity columns
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox