pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Ryoga Yoshida <bt23yoshidar@oss.nttdata.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Aleksander Alekseev <aleksander@timescale.com>
Cc: pgsql-hackers@lists.postgresql.org, Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Subject: Re: Bug fix for psql's meta-command \ev
Date: Wed, 20 Sep 2023 14:08:34 +0900
Message-ID: <0b87efc5a628fe4f1144c2d6879894dc@oss.nttdata.com> (raw)
In-Reply-To: <ZQo9pH4eN9fEvAVN@paquier.xyz>
References: <01419622d84ef093fd4fe585520bf03c@oss.nttdata.com>
	<20230915.151750.1163612305682721014.horikyota.ntt@gmail.com>
	<CAJ7c6TMnvwgDRU5KmcTf_Nqar0mhuc6Q0FEtPnoJkNos_wQAbA@mail.gmail.com>
	<ZQkbVxL9fKZxMwVE@paquier.xyz>
	<CAJ7c6TPBN-C_Y0WP1UnLvMxbBpS7-p7vneoaG96WBN-KsEJ2WQ@mail.gmail.com>
	<ZQo9pH4eN9fEvAVN@paquier.xyz>

On 2023-09-20 09:32, Michael Paquier wrote:
> Actually there was a bit more to it in the presence of \e, that could
> also get some unpredictible behaviors if some errors happen while
> editing a query, which is something unlikely, still leads to strange
> behaviors on failure injections.  I was considering first to move the
> reset in do_edit(), but also we have the case of \e[v|f] where the
> buffer has no edits so it felt a bit more natural to do that in the
> upper layer like in this patch.

Indeed, similar behaviours can happen with the \e. The patch you 
committed looks good to me. Thank you.

Ryoga Yoshida





view thread (10+ messages)

Message-ID: <0b87efc5a628fe4f1144c2d6879894dc@oss.nttdata.com>
Permalink:  ../0b87efc5a628fe4f1144c2d6879894dc@oss.nttdata.com/
Also on:    postgresql.org/message-id/0b87efc5a628fe4f1144c2d6879894dc@oss.nttdata.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: bt23yoshidar@oss.nttdata.com, michael@paquier.xyz, aleksander@timescale.com, horikyota.ntt@gmail.com
  Subject: Re: Bug fix for psql's meta-command \ev
  In-Reply-To: <0b87efc5a628fe4f1144c2d6879894dc@oss.nttdata.com>
  References: <01419622d84ef093fd4fe585520bf03c@oss.nttdata.com> <20230915.151750.1163612305682721014.horikyota.ntt@gmail.com> <CAJ7c6TMnvwgDRU5KmcTf_Nqar0mhuc6Q0FEtPnoJkNos_wQAbA@mail.gmail.com> <ZQkbVxL9fKZxMwVE@paquier.xyz> <CAJ7c6TPBN-C_Y0WP1UnLvMxbBpS7-p7vneoaG96WBN-KsEJ2WQ@mail.gmail.com> <ZQo9pH4eN9fEvAVN@paquier.xyz> <0b87efc5a628fe4f1144c2d6879894dc@oss.nttdata.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox