pg.ddx.io pgsql-hackers@postgresql.org mailing list archive
help / color / mirror / Atom feedExtra code in commit_ts.h
5+ messages / 3 participants
[nested] [flat]
Commits from this thread:
2021-08-08 75a2d132ea Remove unused function declaration
* Extra code in commit_ts.h
@ 2021-08-03 09:36 Andrey V. Lepikhov <a.lepikhov@postgrespro.ru>
2021-08-03 10:16 ` Re: Extra code in commit_ts.h David Rowley <dgrowleyml@gmail.com>
0 siblings, 1 reply; 5+ messages in thread
From: Andrey V. Lepikhov @ 2021-08-03 09:36 UTC (permalink / raw)
To: pgsql-hackers <pgsql-hackers@lists.postgresql.org>
Hi,
I found two extra code lines in commit_ts.h (see attachment).
They confused me during exploring of the code. If they still needed, may
be add some comments?
--
regards,
Andrey Lepikhov
Postgres Professional
Attachments:
excess_code.patch (text/x-patch, 654B) download
diff --git a/src/include/access/commit_ts.h b/src/include/access/commit_ts.h
index e045dd416f..a1538978c6 100644
--- a/src/include/access/commit_ts.h
+++ b/src/include/access/commit_ts.h
@@ -15,14 +15,10 @@
#include "datatype/timestamp.h"
#include "replication/origin.h"
#include "storage/sync.h"
-#include "utils/guc.h"
extern PGDLLIMPORT bool track_commit_timestamp;
-extern bool check_track_commit_timestamp(bool *newval, void **extra,
- GucSource source);
-
extern void TransactionTreeSetCommitTsData(TransactionId xid, int nsubxids,
TransactionId *subxids, TimestampTz timestamp,
RepOriginId nodeid);
* Re: Extra code in commit_ts.h
2021-08-03 09:36 Extra code in commit_ts.h Andrey V. Lepikhov <a.lepikhov@postgrespro.ru>
@ 2021-08-03 10:16 ` David Rowley <dgrowleyml@gmail.com>
2021-08-03 11:12 ` Re: Extra code in commit_ts.h Andrey Lepikhov <a.lepikhov@postgrespro.ru>
0 siblings, 1 reply; 5+ messages in thread
From: David Rowley @ 2021-08-03 10:16 UTC (permalink / raw)
To: Andrey V. Lepikhov <a.lepikhov@postgrespro.ru>; +Cc: pgsql-hackers <pgsql-hackers@lists.postgresql.org>
On Tue, 3 Aug 2021 at 21:36, Andrey V. Lepikhov
<a.lepikhov@postgrespro.ru> wrote:
> I found two extra code lines in commit_ts.h (see attachment).
> They confused me during exploring of the code. If they still needed, may
> be add some comments?
Going by:
$ git config --global diff.renamelimit 1000
$ git diff 73c986adde5~1.. | grep check_track_commit_timestamp
+extern bool check_track_commit_timestamp(bool *newval, void **extra,
that function has never been defined.
David
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: Extra code in commit_ts.h
2021-08-03 09:36 Extra code in commit_ts.h Andrey V. Lepikhov <a.lepikhov@postgrespro.ru>
2021-08-03 10:16 ` Re: Extra code in commit_ts.h David Rowley <dgrowleyml@gmail.com>
@ 2021-08-03 11:12 ` Andrey Lepikhov <a.lepikhov@postgrespro.ru>
2021-08-03 12:02 ` Re: Extra code in commit_ts.h David Rowley <dgrowleyml@gmail.com>
0 siblings, 1 reply; 5+ messages in thread
From: Andrey Lepikhov @ 2021-08-03 11:12 UTC (permalink / raw)
To: David Rowley <dgrowleyml@gmail.com>; +Cc: pgsql-hackers <pgsql-hackers@lists.postgresql.org>
On 3/8/21 15:16, David Rowley wrote:
> it diff 73c986adde5~1.. | grep check_track_commit_timestamp
I think this is waste code. May be delete it?
--
regards,
Andrey Lepikhov
Postgres Professional
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: Extra code in commit_ts.h
2021-08-03 09:36 Extra code in commit_ts.h Andrey V. Lepikhov <a.lepikhov@postgrespro.ru>
2021-08-03 10:16 ` Re: Extra code in commit_ts.h David Rowley <dgrowleyml@gmail.com>
2021-08-03 11:12 ` Re: Extra code in commit_ts.h Andrey Lepikhov <a.lepikhov@postgrespro.ru>
@ 2021-08-03 12:02 ` David Rowley <dgrowleyml@gmail.com>
2021-08-08 11:29 ` Re: Extra code in commit_ts.h David Rowley <dgrowleyml@gmail.com>
0 siblings, 1 reply; 5+ messages in thread
From: David Rowley @ 2021-08-03 12:02 UTC (permalink / raw)
To: Andrey Lepikhov <a.lepikhov@postgrespro.ru>; +Cc: pgsql-hackers <pgsql-hackers@lists.postgresql.org>
On Tue, 3 Aug 2021 at 23:12, Andrey Lepikhov <a.lepikhov@postgrespro.ru> wrote:
>
> On 3/8/21 15:16, David Rowley wrote:
> > it diff 73c986adde5~1.. | grep check_track_commit_timestamp
> I think this is waste code. May be delete it?
Yeah, I think it can be safely removed. I can do so unless someone
thinks otherwise.
David
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: Extra code in commit_ts.h
2021-08-03 09:36 Extra code in commit_ts.h Andrey V. Lepikhov <a.lepikhov@postgrespro.ru>
2021-08-03 10:16 ` Re: Extra code in commit_ts.h David Rowley <dgrowleyml@gmail.com>
2021-08-03 11:12 ` Re: Extra code in commit_ts.h Andrey Lepikhov <a.lepikhov@postgrespro.ru>
2021-08-03 12:02 ` Re: Extra code in commit_ts.h David Rowley <dgrowleyml@gmail.com>
@ 2021-08-08 11:29 ` David Rowley <dgrowleyml@gmail.com>
0 siblings, 0 replies; 5+ messages in thread
From: David Rowley @ 2021-08-08 11:29 UTC (permalink / raw)
To: Andrey Lepikhov <a.lepikhov@postgrespro.ru>; +Cc: pgsql-hackers <pgsql-hackers@lists.postgresql.org>
On Wed, 4 Aug 2021 at 00:02, David Rowley <dgrowleyml@gmail.com> wrote:
> Yeah, I think it can be safely removed. I can do so unless someone
> thinks otherwise.
Pushed.
David
^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2021-08-08 11:29 UTC | newest]
Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-08-03 09:36 Extra code in commit_ts.h Andrey V. Lepikhov <a.lepikhov@postgrespro.ru>
2021-08-03 10:16 ` David Rowley <dgrowleyml@gmail.com>
2021-08-03 11:12 ` Andrey Lepikhov <a.lepikhov@postgrespro.ru>
2021-08-03 12:02 ` David Rowley <dgrowleyml@gmail.com>
2021-08-08 11:29 ` David Rowley <dgrowleyml@gmail.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox