public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: Nazir Bilal Yavuz <[email protected]>
To: pgsql-hackers <[email protected]>
Subject: Re: Remove unnecessary 'always:' from CompilerWarnings task
Date: Wed, 8 Nov 2023 08:31:00 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAN55FZ3o52jRfEn=NEVRV4OxsWO4v-urtS-ADZwfoe=AT5PPCg@mail.gmail.com>
References: <CAN55FZ3o52jRfEn=NEVRV4OxsWO4v-urtS-ADZwfoe=AT5PPCg@mail.gmail.com>

On 05.09.23 12:25, Nazir Bilal Yavuz wrote:
> There are multiple 'always:' keywords under the CompilerWarnings task.
> Instead of that, we can use one 'always:' and move the instructions
> under this. So, I removed unnecessary ones and rearranged indents
> according to that change.

I'm not sure this change is beneficial.  The way the code is currently 
arranged, it's a bit easier to move or change individual blocks, and 
it's also easier to read the file, because the "always:" is next to each 
"script" and doesn't scroll off the screen.

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Remove unnecessary 'always:' from CompilerWarnings task
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox