pg.ddx.io pgsql-hackers@postgresql.org mailing list archive help / color / mirror / Atom feed From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Michael Paquier <michael.paquier@gmail.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: Reviewing freeze map code
Date: Tue, 21 Jun 2016 10:47:30 -0400
Message-ID: <10075.1466520450@sss.pgh.pa.us> (raw )
In-Reply-To: <CA+TgmoaxwkjL=ZVOcXQgKvcjGWn7zzZQNMJFo89kfV6Xs1gDUg@mail.gmail.com >
References: <CA+TgmoYOHNANcr503GDoxwyynLHBwgWeB-6sGF2ikBb=sMQLjw@mail.gmail.com >
<CA+Tgmoan8=YLen3SvJ8Qt51fYALmrkULfvhvPcFvNzrHEMSXAA@mail.gmail.com >
<CA+Tgmob+jC=3LUSSQ0ojA02naKC6yb8ny-SHZp8rEFi8Y-X=BA@mail.gmail.com >
<CAEepm=3kJ-fo9UTf6_4HMsKAHgooPXXFDxDF=jQVehiLx-0Bdw@mail.gmail.com >
<CAEepm=2at9oWWqt-eMxz3rw3stSa+m6LRzeM+J+iXKBkUJx9FQ@mail.gmail.com >
<CA+TgmoZ-1TXCsxWcp3i-KMo5DNB-6p-odqw7c-N_q3pzZY1TJg@mail.gmail.com >
<20160620193302.s4dbul6japgar5eg@alap3.anarazel.de >
<CA+TgmobBaJtjQxM0vNbTcUbZ1Buai6a9aTk4b4yt3gNKGPUe-A@mail.gmail.com >
<20160620202453.zg66rvbhmvzl7ihn@alap3.anarazel.de >
<CA+TgmobpkmbNd5HCwYyKu0rMcL3mzEYM78689-Wh=FJFY9BuOw@mail.gmail.com >
<20160620215943.73hekh5phsq65uk5@alap3.anarazel.de >
<CA+TgmoaxwkjL=ZVOcXQgKvcjGWn7zzZQNMJFo89kfV6Xs1gDUg@mail.gmail.com >
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Robert Haas <robertmhaas@gmail.com> writes:
> On Mon, Jun 20, 2016 at 5:59 PM, Andres Freund <andres@anarazel.de> wrote:
>> Consider what happens if we, after restarting at l2, notice that we
>> can't actually insert, but return in the !HeapTupleMayBeUpdated
>> branch.
> OK, I see what you mean. Still, that doesn't seem like such a
> terrible cost. If you try to update a tuple and if it looks like you
> can update it but then after TOASTing you find that the status of the
> tuple has changed such that you can't update it after all, then you
> might need to go set xmax = MyTxid() on all of the TOAST tuples you
> created (whose CTIDs we could save someplace, so that it's just a
> matter of finding them by CTID to kill them).
... and if you get an error or crash partway through that, what happens?
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
view thread (256+ messages) latest in thread
Message-ID: <10075.1466520450@sss.pgh.pa.us>
Permalink: ../10075.1466520450@sss.pgh.pa.us/
Also on: postgresql.org/message-id/10075.1466520450@sss.pgh.pa.us
copy link · copy postgr.es
reply Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com, andres@anarazel.de, thomas.munro@enterprisedb.com, alvherre@2ndquadrant.com, amit.kapila16@gmail.com, sfrost@snowman.net, michael.paquier@gmail.com, sawada.mshk@gmail.com
Subject: Re: Reviewing freeze map code
In-Reply-To: <10075.1466520450@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox