From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: remove ancient pre-dlopen dynloader code
Date: Thu, 16 Aug 2018 10:07:04 -0400
Message-ID: <10102.1534428424@sss.pgh.pa.us> (raw)
In-Reply-To: <20180816135928.qer5o7uxyaeolzet@alap3.anarazel.de>
References: <3e3c7552-978b-486a-1a4a-326ee31d0545@2ndquadrant.com>
<20180809123059.32g25qn7dgd33iyq@alap3.anarazel.de>
<26726.1533823423@sss.pgh.pa.us>
<20180816083107.2f5gxbvlsgvnuit4@alap3.anarazel.de>
<8022.1534425734@sss.pgh.pa.us>
<20180816135928.qer5o7uxyaeolzet@alap3.anarazel.de>
Andres Freund <andres@anarazel.de> writes:
> On 2018-08-16 09:22:14 -0400, Tom Lane wrote:
>> The lazy man's way to get rid of it would be to put something like
>> "int bogus = 0;" in the empty dynloader.c files. Better would be
>> to not have the empty .c files at all, but I'm not sure how much
>> we'd have to contort the Makefiles to support that.
> If I had my druthers, we'd just remove all that configure magic for
> selecting these files and just use ifdefs. Personally I find it
> occasionally that they're linked into place, rather than built under
> their original name.
Even if we all agreed that was an improvement (which I'm not sure of),
it wouldn't fix this problem would it? On affected platforms, the
file would still be empty after preprocessing.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, peter.eisentraut@2ndquadrant.com
Subject: Re: remove ancient pre-dlopen dynloader code
In-Reply-To: <10102.1534428424@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox