From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: SKIP_LOCKED test causes random buildfarm failures
Date: Thu, 14 Nov 2019 15:20:09 -0500
Message-ID: <10268.1573762809@sss.pgh.pa.us> (raw)
In-Reply-To: <20191114201608.m763meogfkk6qpjh@alap3.anarazel.de>
References: <25294.1573077278@sss.pgh.pa.us>
<20191106230111.2kmd6hnriqttw6ys@alap3.anarazel.de>
<20191107013942.GA1768@paquier.xyz>
<12732.1573145425@sss.pgh.pa.us>
<5815.1573756664@sss.pgh.pa.us>
<20191114201608.m763meogfkk6qpjh@alap3.anarazel.de>
Andres Freund <andres@anarazel.de> writes:
> On 2019-11-14 13:37:44 -0500, Tom Lane wrote:
>> As for the SKIP_LOCKED tests in vacuum.sql, what I now propose is that
>> we just remove them. I do not see that they're offering any coverage
>> that's not completely redundant with this isolation test. We don't
>> need to spend cycles every day on that.
> -0 on that, I'd rather just put a autovacuum_enabled = false for
> them. They're quick enough, and it's nice to have decent coverage of
> various options within the plain regression tests when possible.
If we're going to keep them in vacuum.sql, we should use the
client_min_messages fix there, as that's a full solution not just
reducing the window. But I don't agree that these tests are worth
the cycles, given the coverage elsewhere. The probability of breaking
this option is just not high enough to justify core-regression-test
coverage.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, michael@paquier.xyz, pgsql-hackers@lists.postgresql.org
Subject: Re: SKIP_LOCKED test causes random buildfarm failures
In-Reply-To: <10268.1573762809@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox