pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Geoghegan <pg@bowt.ie>
Cc: Jeff Davis <pgsql@j-davis.com>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Melanie Plageman <melanieplageman@gmail.com>
Cc: Soumyadeep Chakraborty <sochakraborty@pivotal.io>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Cc: soumyadeep2007@gmail.com
Subject: Re: Memory Accounting
Date: Fri, 04 Oct 2019 14:58:49 -0400
Message-ID: <10470.1570215529@sss.pgh.pa.us> (raw)
In-Reply-To: <CAH2-Wzm8Nh7Ky-OpoNYQLAg3VGjkxqjeKfnKroQ=Ppk6STvuyg@mail.gmail.com>
References: <CADwEdor2jZitB2P94on2LUAhdi0iRHv2WNseV3LJmJPenuuNpw@mail.gmail.com>
	<67f66d2fa39e35aef90093c74531a38dcd5c0f73.camel@j-davis.com>
	<CAAKRu_b2Qxr=GzE7thk8_=JDgYRnOssYBuqWdZ39R2+Heo=oQw@mail.gmail.com>
	<20190926192244.mk5ru6nkofo7am3h@development>
	<57780817877d4b40106b248b63261e21a7a56261.camel@j-davis.com>
	<20190928221249.mo2jrtlakingnc5e@development>
	<20190928222206.thidzeygazl7axhg@development>
	<392e034c1b674a1a58c217dc440ea6197081ccfa.camel@j-davis.com>
	<20191001021114.iimd77xgnstaww7j@development>
	<15151.1570163761@sss.pgh.pa.us>
	<20191004082644.wytixiukkm6ditlu@development>
	<0278d32083d051f165c75d605d9fd1a82a197ef8.camel@j-davis.com>
	<CAH2-Wzm8Nh7Ky-OpoNYQLAg3VGjkxqjeKfnKroQ=Ppk6STvuyg@mail.gmail.com>

Peter Geoghegan <pg@bowt.ie> writes:
> On Fri, Oct 4, 2019 at 7:32 AM Jeff Davis <pgsql@j-davis.com> wrote:
>> The patch has been floating around for a very long time, so I don't
>> remember exactly why I chose a signed value. Sorry.

> I am reminded of the fact that int64 is used to size buffers within
> tuplesort.c, because it needs to support negative availMem sizes --
> when huge allocations were first supported, tuplesort.c briefly used
> "Size", which didn't work. Perhaps it had something to do with that.

I wonder if we should make that use ssize_t instead.  Probably
not worth the trouble.

			regards, tom lane





view thread (28+ messages)  latest in thread

Message-ID: <10470.1570215529@sss.pgh.pa.us>
Permalink:  ../10470.1570215529@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/10470.1570215529@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pg@bowt.ie, pgsql@j-davis.com, tomas.vondra@2ndquadrant.com, melanieplageman@gmail.com, sochakraborty@pivotal.io, robertmhaas@gmail.com, soumyadeep2007@gmail.com
  Subject: Re: Memory Accounting
  In-Reply-To: <10470.1570215529@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox