pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Amit Langote <amitlangote09@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: sqlsmith: ERROR: XX000: bogus varno: 2
Date: Thu, 06 Jan 2022 10:24:09 -0500
Message-ID: <1070417.1641482649@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+HiwqFLonz9AnjixmatcOF6ryKyywXqYW4S6Eu0s8gtZ4pMgg@mail.gmail.com>
References: <20211219205422.GT17618@telsasoft.com>
	<2209221.1639948636@sss.pgh.pa.us>
	<CA+TgmobHkyGKM_DOgzGbh7BiWXdBGLMTnmB2S_FyyNHgqTxqBg@mail.gmail.com>
	<2445883.1640017555@sss.pgh.pa.us>
	<CA+Tgmoa7JFTYxM4AJEk+bM_J4Y+1sxQY+rAN3wE+ZmkbqWkCEA@mail.gmail.com>
	<2524668.1640024031@sss.pgh.pa.us>
	<CA+Tgmob2wVbfj47aqFxYeTuP_rcO45dip_GU-Hz=BSxu4POgXw@mail.gmail.com>
	<2598851.1640028995@sss.pgh.pa.us>
	<CA+TgmoYz=M+2Z-heoBzJHAzs6heY=4icZ=-b5z6d2+XUw5CeRA@mail.gmail.com>
	<2657967.1640035211@sss.pgh.pa.us>
	<CA+HiwqFLonz9AnjixmatcOF6ryKyywXqYW4S6Eu0s8gtZ4pMgg@mail.gmail.com>

Amit Langote <amitlangote09@gmail.com> writes:
> Thanks for addressing that in the patch you posted.  I guess fixing
> only expression_tree_walker/mutator() suffices for now, but curious to
> know if it was intentional that you decided not to touch the following
> sites:

> exprCollation(): it would perhaps make sense to return the collation
> assigned to the 1st element of listdatums/lowerdatums/upperdatums,
> especially given that transformPartitionBoundValue() does assign a
> collation to the values in those lists based on the parent's partition
> key specification.

But each column could have a different collation, no?  I do not
think it's sensible to pick one of those at random and claim
that's the collation of the whole thing.  So throwing an error
seems appropriate.

> exprType(): could be handled similarly

The same, in spades.  Anybody who is asking for "the type"
of a relpartbound is misguided.

> queryjumble.c: JumbleExpr(): whose header comment says:

If somebody needs that, I wouldn't object to adding support there.
But right now it would just be dead code, so why bother?

			regards, tom lane





view thread (16+ messages)  latest in thread

Message-ID: <1070417.1641482649@sss.pgh.pa.us>
Permalink:  ../1070417.1641482649@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1070417.1641482649@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, amitlangote09@gmail.com, robertmhaas@gmail.com, pryzby@telsasoft.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: sqlsmith: ERROR: XX000: bogus varno: 2
  In-Reply-To: <1070417.1641482649@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox