From: Tom Lane <tgl@sss.pgh.pa.us>
To: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Rajkumar Raghuwanshi <rajkumar.raghuwanshi@enterprisedb.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Getting ERROR: could not open file "base/13164/t3_16388" with partition table with ON COMMIT
Date: Thu, 13 Sep 2018 10:13:41 -0400
Message-ID: <10741.1536848021@sss.pgh.pa.us> (raw)
In-Reply-To: <e1b7c3ec-dbfc-4295-8bec-ee985114ecb5@lab.ntt.co.jp>
References: <CAKcux6mhgcjSiB_egqEAEFgX462QZtncU8QCAJ2HZwM-wWGVew@mail.gmail.com>
<2bf804fb-7417-4539-51c5-f6419f1e8741@lab.ntt.co.jp>
<7193.1536768840@sss.pgh.pa.us>
<e1b7c3ec-dbfc-4295-8bec-ee985114ecb5@lab.ntt.co.jp>
Amit Langote <Langote_Amit_f8@lab.ntt.co.jp> writes:
> On 2018/09/13 1:14, Tom Lane wrote:
>> That seems excessively restrictive. Anything that has storage (e.g.
>> matviews) ought to be truncatable, no?
> Not by heap_truncate it seems. The header comment of heap_truncate says
> that it concerns itself only with ON COMMIT truncation of temporary tables:
Ah. Well, in that case I'm OK with just a simple test for
RELKIND_RELATION, but I definitely feel that it should be inside
heap_truncate. Callers don't need to know about the limited scope
of what that does.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, Langote_Amit_f8@lab.ntt.co.jp, rajkumar.raghuwanshi@enterprisedb.com
Subject: Re: Getting ERROR: could not open file "base/13164/t3_16388" with partition table with ON COMMIT
In-Reply-To: <10741.1536848021@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox