From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Álvaro Herrera <alvherre@kurilemu.de>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Translation of the NextOID message in pg_controldata
Date: Mon, 14 Sep 2026 09:57:08 -0400
Message-ID: <109494.1789394228@sss.pgh.pa.us> (raw)
In-Reply-To: <aqedWuHgzxirUrLo@paquier.xyz>
References: <aqeNcd4403BGVZqc@paquier.xyz>
<aqeO1OU7uZjhioAq@alvherre.pgsql>
<aqedWuHgzxirUrLo@paquier.xyz>
Michael Paquier <michael@paquier.xyz> writes:
> On Mon, Sep 14, 2026 at 08:41:59AM +0200, Alvaro Herrera wrote:
>> I'm not sure I understand why we care that we hardcode that Oid8 is the
>> same as uint64. It's never been a problem that Oid is the same as uin32 ...
> For me, the reason is greppability of oid8 information as the
> variables printed in the strings may not refer to variables declared
> in the code.
Yeah. It's not a big deal, so maybe PRIu64 is the best option.
I just wanted to be sure we'd considered whether there's another way.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, alvherre@kurilemu.de, horikyota.ntt@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Translation of the NextOID message in pg_controldata
In-Reply-To: <109494.1789394228@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox