From: Tom Lane <tgl@sss.pgh.pa.us>
To: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
Cc: andres@anarazel.de
Cc: michael@paquier.xyz
Cc: kuntalghosh.2007@gmail.com
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Regression test PANICs with master-standby setup on same machine
Date: Wed, 24 Apr 2019 10:13:09 -0400
Message-ID: <10967.1556115189@sss.pgh.pa.us> (raw)
In-Reply-To: <20190424.170228.203880527.horiguchi.kyotaro@lab.ntt.co.jp>
References: <20190423170503.uw5jxrujqlozg23l@alap3.anarazel.de>
<20190424.131845.116224815.horiguchi.kyotaro@lab.ntt.co.jp>
<20190424.132304.40676137.horiguchi.kyotaro@lab.ntt.co.jp>
<20190424.170228.203880527.horiguchi.kyotaro@lab.ntt.co.jp>
Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp> writes:
> At Wed, 24 Apr 2019 13:23:04 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp> wrote in <20190424.132304.40676137.horiguchi.kyotaro@lab.ntt.co.jp>
>> We need to adjust relative path between PGDATA-based and
>> pg_tblspc based. The attached first patch does that.
> This is new version. Adjusted pg_basebackup's behavior to allow
> relative mappings. But..
I can't say that I like 0001 at all. It adds a bunch of complication and
new failure modes (e.g., having to panic on chdir failure) in order to do
what exactly? I've not been following the thread closely, but the
original problem is surely just a dont-do-that misconfiguration. I also
suspect that this is assuming way too much about the semantics of getcwd
--- some filesystem configurations may have funny situations like multiple
paths to the same place.
0004 also seems like it's adding at least as many failure modes as
it removes. Moreover, isn't it just postponing the failure a little?
Later WAL might well try to touch the directory you skipped creation of.
We can't realistically decide that all WAL-application errors are
ignorable, but that seems like the direction this would have us go in.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, horiguchi.kyotaro@lab.ntt.co.jp, andres@anarazel.de, michael@paquier.xyz, kuntalghosh.2007@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Regression test PANICs with master-standby setup on same machine
In-Reply-To: <10967.1556115189@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox