From: Tom Lane <tgl@sss.pgh.pa.us>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: vignesh C <vignesh21@gmail.com>
Cc: Jerry Sievers <gsievers19@comcast.net>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: SegFault on 9.6.14
Date: Wed, 14 Aug 2019 00:52:18 -0400
Message-ID: <11301.1565758338@sss.pgh.pa.us> (raw)
In-Reply-To: <CAA4eK1KzUD91YYPe3xj416TZQzP4Ubm=oQNt_e-KBiSBTDKd7A@mail.gmail.com>
References: <CA+hUKGK=dChcQtgf1-r73XEqDhW1VD32Tf9qDi39aYbjuE3mGA@mail.gmail.com>
<20190812190749.GA13961@alvherre.pgsql>
<CA+TgmoZHcMqmwtnfW6X3gyJW84S5LxERVmNPobXtmrQkJh+x4A@mail.gmail.com>
<14905.1565646513@sss.pgh.pa.us>
<CAA4eK1+NSijDZA3gBd+-y5CcM7hdvtRHPCrbXFPp1idPVMKBXQ@mail.gmail.com>
<4832.1565711932@sss.pgh.pa.us>
<CAA4eK1KzUD91YYPe3xj416TZQzP4Ubm=oQNt_e-KBiSBTDKd7A@mail.gmail.com>
Amit Kapila <amit.kapila16@gmail.com> writes:
> Another point which I am wondering is why can't we use the existing
> REWIND flag to solve the current issue, basically if we have access to
> that information in nodeLimit.c (ExecLimit), then can't we just pass
> down that to ExecShutdownNode?
The existing REWIND flag tells subnodes whether they should *optimize*
for getting rewound or not. I don't recall right now (well past
midnight) why that seemed like a useful definition, but if you grep for
places that are paying attention to that flag, I'm sure you'll find out.
We probably don't want to give up that distinction --- if it had been
equally good to define the flag as a hard yes-or-no, I'm sure we would
have taken that definition, because it's simpler.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, amit.kapila16@gmail.com, robertmhaas@gmail.com, alvherre@2ndquadrant.com, thomas.munro@gmail.com, vignesh21@gmail.com, gsievers19@comcast.net, tomas.vondra@2ndquadrant.com
Subject: Re: SegFault on 9.6.14
In-Reply-To: <11301.1565758338@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox