From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bossart, Nathan <bossartn@amazon.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: michael@paquier.xyz <michael@paquier.xyz>
Cc: andres@anarazel.de <andres@anarazel.de>
Cc: sulamul@gmail.com <sulamul@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: inefficient loop in StandbyReleaseLockList()
Date: Mon, 01 Nov 2021 12:57:27 -0400
Message-ID: <1142780.1635785847@sss.pgh.pa.us> (raw)
In-Reply-To: <C84534A6-2E66-47FF-B193-EBB566544D49@amazon.com>
References: <0108A03D-FF2B-4CBC-933B-E047CD975158@amazon.com>
<1013797.1635709095@sss.pgh.pa.us>
<1043766.1635713701@sss.pgh.pa.us>
<20211101.114019.1470121542110379535.horikyota.ntt@gmail.com>
<1138901.1635782315@sss.pgh.pa.us>
<C84534A6-2E66-47FF-B193-EBB566544D49@amazon.com>
"Bossart, Nathan" <bossartn@amazon.com> writes:
> On 10/31/21, 1:55 PM, "Tom Lane" <tgl@sss.pgh.pa.us> wrote:
>> 1. Attached is a proposed patch to get rid of the calls in trgm_regexp.c.
> Should there be a list_free(trgmNFA->queue) at the end of
> transformGraph()?
There could be, but that's visibly invoked only once per
createTrgmNFAInternal call, so I didn't think it was worthwhile
to do so (unlike the case for processState). If we were concerned
about leakage in that function, the hash table would be a far
bigger issue.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, bossartn@amazon.com, horikyota.ntt@gmail.com, michael@paquier.xyz, andres@anarazel.de, sulamul@gmail.com
Subject: Re: inefficient loop in StandbyReleaseLockList()
In-Reply-To: <1142780.1635785847@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox