agora inbox for pgsql-hackers@postgresql.org
help / color / mirror / Atom feedFrom: Antonin Houska <ah@cybertec.at>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Mihail Nikalayeu <mihailnikalayeu@gmail.com>
Cc: Robert Treat <rob@xzilla.net>
Subject: Re: Adding REPACK [concurrently]
Date: Thu, 04 Dec 2025 18:43:27 +0100
Message-ID: <116433.1764870207@localhost> (raw)
In-Reply-To: <202510301734.pj4uds3mqxx4@alvherre.pgsql>
References: <202510301734.pj4uds3mqxx4@alvherre.pgsql>
Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
> Here's a new installment of this series, v25, including the CONCURRENTLY
> part, which required some conflict fixes on top of the much-changed
> v24-0001 patch.
v26 attached here. It's been rebased and reflects most of the feedback.
A few incomplete items are marked as TBD here [1] and [2] is another thing
that needs discussion.
Besides that, I've done some refactoring in 0004: 1) move more code to
setup_logical_decoding(), and 2) reduced the number of arguments of
process_concurrent_changes() by using a new structure. Both these changes are
a preparation for a background worker that will perform the logical decoding,
but seem to be useful as such. (I have a PoC of the worker but will post it
later, it doesn't seem to be the priority for now.)
I've also removed support for decoding TRUNCATE because I realized that this
command uses AccessExclusiveLock, so it cannot be executed on a table that
REPACK (CONCURRENTLY) is just processing.
Also I tried to fix TAB completion in psql.
> I have not yet addressed Robert Treat's feedback from October 12th.
These are still pending.
[1] https://www.postgresql.org/message-id/23631.1764855372%40localhost
[2] https://www.postgresql.org/message-id/CAJSLCQ2_jX8WmNOC4eu6hL5QyNHceOkgPbGhKHFw2X5onVEKDQ%40mail.gma...
--
Antonin Houska
Web: https://www.cybertec-postgresql.com
Attachments:
[text/x-diff] v26-0001-Add-REPACK-command.patch (0B, ../116433.1764870207@localhost/2-v26-0001-Add-REPACK-command.patch)
download
view thread (416+ messages) latest in thread
Message-ID: <116433.1764870207@localhost>
Permalink: ../116433.1764870207@localhost/
Also on: postgresql.org/message-id/116433.1764870207@localhost
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: ah@cybertec.at, alvherre@alvh.no-ip.org, pgsql-hackers@lists.postgresql.org, mihailnikalayeu@gmail.com, rob@xzilla.net
Subject: Re: Adding REPACK [concurrently]
In-Reply-To: <116433.1764870207@localhost>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox