public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: Nathan Bossart <[email protected]>
Cc: Fujii Masao <[email protected]>
Cc: Andy Fan <[email protected]>
Cc: [email protected]
Subject: Re: convert libpgport's pqsignal() to a void function
Date: Tue, 14 Jan 2025 22:02:46 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <Z4chOKfnthRH71mw@nathan>
References: <Z4chOKfnthRH71mw@nathan>

Nathan Bossart <[email protected]> writes:
> Thanks to commit 9a45a89, legacy-pqsignal.c now has its own dedicated
> extern for pqsignal(), which decouples it enough that we can follow through
> with changing libpqport's pqsignal() to a void function.

> Thoughts?

LGTM, although I don't know enough about Windows to know if the
"== SIG_ERR" test in that path is correct.

			regards, tom lane

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: convert libpgport's pqsignal() to a void function
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox