From: Ronan Dunklau <ronan@dunklau.fr>
To: Michael Paquier <michael@paquier.xyz>
Cc: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Preserve attstattarget on REINDEX CONCURRENTLY
Date: Fri, 05 Feb 2021 08:22:17 +0100
Message-ID: <11797662.T7Z3S40VBb@laptop-ronand> (raw)
In-Reply-To: <YByqzE9qu16vuEB+@paquier.xyz>
References: <16628084.uLZWGnKmhe@laptop-ronand>
<80274775044a11f6f42af9c39640a055@dunklau.fr>
<YByqzE9qu16vuEB+@paquier.xyz>
Le vendredi 5 février 2021, 03:17:48 CET Michael Paquier a écrit :
> ConstructTupleDescriptor() does not matter much, but this patch is not
> acceptable to me as it touches the area of the index creation while
> statistics on an index expression can only be changed with a special
> flavor of ALTER INDEX with column numbers. This would imply an ABI
> breakage, so it cannot be backpatched as-is.
I'm not surprised by this answer, the good news is it's being back-patched.
>
> Let's copy this data in index_concurrently_swap() instead. The
> attached patch does that, and adds a test cheaper than what was
> proposed. There is a minor release planned for next week, so I may be
> better to wait after that so as we have enough time to agree on a
> solution.
Looks good to me ! Thank you.
--
Ronan Dunklau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: ronan@dunklau.fr, michael@paquier.xyz, tomas.vondra@enterprisedb.com
Subject: Re: Preserve attstattarget on REINDEX CONCURRENTLY
In-Reply-To: <11797662.T7Z3S40VBb@laptop-ronand>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox