pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: Better way to handle suppression of CASCADE detail messages
Date: Tue, 01 Aug 2017 13:57:42 -0400
Message-ID: <11852.1501610262@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+TgmoZ5CP=DZhyL90TJ6NN1L-7_G8esfLdPRRvpqO6JSYS7kQ@mail.gmail.com>
References: <10766.1501608885@sss.pgh.pa.us>
	<20170801173922.txyo6nr4j5grgipf@alap3.anarazel.de>
	<CA+TgmoZ5CP=DZhyL90TJ6NN1L-7_G8esfLdPRRvpqO6JSYS7kQ@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

Robert Haas <robertmhaas@gmail.com> writes:
> On Tue, Aug 1, 2017 at 1:39 PM, Andres Freund <andres@anarazel.de> wrote:
>> Oid is probably not good enough - with parallel tests and such it's not
>> necessarily predicable. Even less so when the tests are run against an
>> existing cluster.  Sorting by name would probably be better...

> It's arguably more user-friendly, too, although part of me feels like
> it would be better to try to preserve the topological ordering in some
> way.

Yeah, loss of the causality relationship is the main thing that's bugging
me too.

If we sorted by OID then in most cases the objects would be listed in
creation order, which would likely also have something to do with the
dependency order; but it would be different in the same cases that are
most likely to be confusing :-(

I do not buy Andres' concern about parallelism breaking the test results.
We only ever drop objects created in the same test, so their OID ordering
would be the same (ie creation order) in every case unless an OID
wraparound occurred mid-test, which isn't a situation I feel a need to
worry about for this purpose.  However, possible loss of user friendliness
*is* a valid concern here.

Anyway, we don't need a design for this today.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (6+ messages)  latest in thread

Message-ID: <11852.1501610262@sss.pgh.pa.us>
Permalink:  ../11852.1501610262@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/11852.1501610262@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com, andres@anarazel.de
  Subject: Re: Better way to handle suppression of CASCADE detail messages
  In-Reply-To: <11852.1501610262@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox